It's not necessarily clear whether drush fn-hook expects "hook_HOOKNAME" or just "HOOKNAME". A little simple clarifying text in the help and an example would make it obvious. Patch to follow.

CommentFileSizeAuthor
#8 devel-clarify-fn-hook-1917514-8.patch761 bytestraviscarden
#1 drush-clarify-fn-hook-1917514-1.patch799 bytestraviscarden

Comments

traviscarden’s picture

traviscarden commented
Assigned: traviscarden » Unassigned
Status: Active » Needs review
Issue tags: +Novice
StatusFileSize
new drush-clarify-fn-hook-1917514-1.patch799 bytes
traviscarden’s picture

traviscarden commented
Issue tags: +Needs backport to D6, +Needs backport to D7

Oh, one more thing. The patch should apply equally well on D6-D8.

juampynr’s picture

juampynr commented
Status: Needs review » Fixed

Fixed. Thanks!

http://drupalcode.org/project/devel.git/commitdiff/b1c68bc

salvis’s picture

salvis
he/his
commented
Status: Fixed » Patch (to be ported)

@juampy: Since you list only one commitdiff I have to ask: did you commit to all three branches?

If yes, then please clear the tags.

juampynr’s picture

juampynr commented
Status: Patch (to be ported) » Fixed
Issue tags: -Needs backport to D6, -Needs backport to D7

Thanks for reminding it @salvis. Backported to D7. Feel free to reopen and submit a backport for D6 (patch does not apply).

salvis’s picture

salvis
he/his
commented
Issue tags: +Needs backport to D6

Thanks

traviscarden’s picture

traviscarden commented
Assigned: Unassigned » traviscarden
Status: Fixed » Patch (to be ported)

I'll get back to this, but not right away...

traviscarden’s picture

traviscarden commented
Version: 8.x-1.x-dev » 6.x-1.x-dev
Status: Patch (to be ported) » Reviewed & tested by the community
StatusFileSize
new devel-clarify-fn-hook-1917514-8.patch761 bytes

Here's a patch for D6. I'll just set this back to RTBC since it's so trivial and I didn't change anything.

moshe weitzman’s picture

moshe weitzman commented
Issue summary: View changes
Status: Reviewed & tested by the community » Fixed

Committed to 6.x Sorry about the 18 month delay.

traviscarden’s picture

traviscarden commented
Assigned: traviscarden » Unassigned

Lol. Thanks.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.