Tweet moderation

This issue could lead to some sort of moderation #1850542: Add ability to retrieve favorite tweets from a Twitter account, but it has not been implemented yet.

If you really want to be able to moderate each tweet (or been able to delete tweets), at the moment there is no such feature. I wonder if adding a Delete link would help.

This patch applied (With some offsets, but otherwise cleanly), and works perfectly for our needs.

The attached patch is a re-roll of tiagojsag's patch against current dev.

It removes some trailing whitespace errors, and also renames the permission from "moderate posts" to "moderate tweets" which seems more appropriate.

Triggering the testbot.

Triggering the testbot.

Rerolled.

Fixed the dupe update script.

Re-rolled the patch against current dev. since the previous patch no longer applies. Fairly manual process - so would be good to get some more eyes on this although it is working for me so far.

The patch applies for me locally. What is happening for me is, no tweets are publishing unless I check the "publish" box next to the tweets, which I see even if the "moderated" box is checked. Is this normal? So no matter if the "Moderated" box is checked after I add my twitter account, I still need to check a publish box to publish tweets. Sorry if I have misunderstood this.

My process:

1) Added my twitter account/creds, etc.
2) checked "tweets", "mentions" and "moderated"
3) viewed the "tweets" tab to see tweets after running cron
4) needed to check the "publish" box next to a tweet/s in order for tweets to publish. I had to do this regardless of whether or not "moderated" was checked.

Also, I realize this is 2 years old and may need to be updated/rerolled.

Thanks for other thoughts, etc. I'll continue to play around with it and make sure I'm doing things correctly.

The patch still applies cleanly, though it does add an extra line at the end of twitter.install. I did not test functionality or look at the code changes.

Okay, I ran into some PHP notices that are a result of the patch, so more work needs to be done with it:

Notice: Undefined index: moderated in twitter_account_load() (line 122 of /srv/vcs/git/drupal/modules/twitter/7.x-5.x/twitter.inc).

Those PHP notices might be because I didn't run any updates. So feel free to revert the status, if updating is needed.