'field types' =>  array('office_hours_formatter_default', 'office_hours', 'office_hours_multiple_values', 'office_hours_select'),
      'multiple values' => FIELD_BEHAVIOR_DEFAULT,

there's only a field type, and 'multiple values' is not a valid key in hook_formatter_info()

CommentFileSizeAuthor
#1 office_hours-1913010.patch2.04 KBjonhattan

Comments

jonhattan’s picture

jonhattan
Primary language Spanish
Location Plasencia
commented
StatusFileSize
new office_hours-1913010.patch2.04 KB

Also changed some docstrings in this patch.

jonhattan’s picture

jonhattan
Primary language Spanish
Location Plasencia
commented
Status: Active » Needs review
johnv’s picture

johnv
Primary language Dutch
commented
Status: Needs review » Needs work

The docstrings have been committed.
I am not confident about the change in office_hours_field_formatter_info(). Some/all of these types are declared in file office_hours.elements.inc : '#type' => 'office_hours_select',

This needs some more investigation and testing.
Can you provide a clean patch?

jonhattan’s picture

jonhattan
Primary language Spanish
Location Plasencia
commented

field types are not form elements.

johnv’s picture

johnv
Primary language Dutch
commented
Status: Needs work » Fixed

Meanwhile, this is fixed while committing your other patches. Thanks.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.