Field settings should be inalterable once it has data, to prevent data inconsistency.

CommentFileSizeAuthor
#1 office_hours-1913008.patch3.11 KBjonhattan

Comments

jonhattan’s picture

jonhattan
Primary language Spanish
Location Plasencia
commented
Status: Active » Needs review
StatusFileSize
new office_hours-1913008.patch3.11 KB

This path disabled all the settings options. I'm not sure if some of them could stay enabled with impact. For example I think the 12/24 format doesn't affect the storage format --perhaps it should be moved to the widget / formatter settings.

johnv’s picture

johnv
Primary language Dutch
commented
Status: Needs review » Closed (won't fix)

IMO these options should stay enabled. Indeed, you might have data loss when you set the 'allowed minutes' to a lower frequency, but that would be the only one. I don't want to take away the possiblility from administrator to fine-tune the widget when the site is live.

The patch contains a second, unrelated part. Please open a second issue if it deserves one. Thanks.

jonhattan’s picture

jonhattan
Primary language Spanish
Location Plasencia
commented
Status: Closed (won't fix) » Needs work

Let's examine which options can safely stay enabled.

* Hours format 12/24: doesn't affect since the backend stores hours in 24h format always.
* Granularity: affects since some data in the backend may become invalid.
* Display add more link: doesn't affect.
* Validate hours: affects since the backend may contain invalid hours: opening throught midnight.
* Limit widget hours: affects since may contain invalid hours: already published hours may be out of the range.

So I suggest disabling granularity, validate_hours and limit.

johnv’s picture

johnv
Primary language Dutch
commented
Status: Needs work » Closed (won't fix)

Let's leave this as it is.