Closed (fixed)
Project:
Range
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
9 Feb 2013 at 13:42 UTC
Updated:
30 Oct 2014 at 09:44 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
taran2lComment #2
Sk8erPeter commentedDo you have any plans for this? :)
thepearson solved it in the ex-Ranges module (mentioned in #1912804: Merge with thepearson's Ranges sandbox module?) with providing separate prefix and suffix instance settings for the separate start and end values.
Here are some relevant code snippets taken from the file ranges.module, see the
['start']['prefix'],['start']['suffix'],['end']['prefix']and['end']['suffix']array indices:line 55-95:
line 200-353 :
line 356-389:
line 518-536:
etc.
Thanks in advance!
Comment #3
taran2lThanks, committed and pushed.
Comment #4
Sk8erPeter commentedWow, thank you very much, Taran2L! :) I've just tested it, and it works.
And I'm really sorry that I reopen this issue, but couldn't we ALSO keep the old prefixes and suffixes, like the ex-Ranges module did? (Sorry that I didn't mention it in the original feature request. :( )
I know it may sound silly, but there may be some weird cases it's needed, and it would be much better to keep another additional opportunity to make this module even better.
So what I'm thinking about is the following (see WRAPPERPREFIX and WRAPPERSUFFIX):
WRAPPERPREFIX testprefix 1234 testsuffix — another testprefix 234132 another testsuffix WRAPPERSUFFIX
This is how it looks like now:
What I think would be even better:
And this is what the field edit form would look like:
I hope you won't find this a silly idea, and there's a chance to implement it too (e.g. with putting back some parts of the old code).
I'll try to help with a patch as soon as I'll have time if needed.
Thank you very much in advance again!
Comment #5
oleh chemerys commentedHere is a patch adding whole field value wrapper.
Comment #6
taran2lLooks good, except couple things:
Can be simplified to
Use single quotes.
Comment #7
taran2lComment #8
oleh chemerys commentedThanks for suggestions, here is an update.
Comment #9
taran2lThanks, reviewed and committed (with some small changes).