Support from Acquia helps fund testing for Drupal Acquia logo

Comments

adammalone’s picture

Status: Active » Needs review
FileSize
1.54 KB

I've included the timeout but it can always be removed if not needed.

Berdir’s picture

Status: Needs review » Needs work
+++ b/core/modules/search/lib/Drupal/search/Tests/SearchRankingTest.phpundefined
@@ -16,6 +16,13 @@ class SearchRankingTest extends SearchTestBase {
 
+  /**
+   * The Guzzle HTTP client.
+   *
+   * @var \Guzzle\Http\ClientInterface;
+   */
+  protected $client;

I don't think this is necessary, it's just used once, so just do $client = ...

+++ b/core/modules/search/lib/Drupal/search/Tests/SearchRankingTest.phpundefined
@@ -80,13 +87,15 @@ function testRankings() {
+    $this->client = drupal_container()->get('http_default_client');

This should now use \Drupal::httpClient()

Berdir’s picture

Status: Needs work » Needs review
FileSize
1.16 KB

Looks like guzzle defaults to that content type header if you pass in an array of post fields. Neat.

ParisLiakos’s picture

Status: Reviewed & tested by the community » Needs review

..double post, see below..

ParisLiakos’s picture

Status: Needs review » Reviewed & tested by the community

It makes sense:)
and this is where statistics.php is being used..i ll know where to look when i will rename it

heh, this looks good, thanks!

webchick’s picture

Status: Needs review » Fixed

All right, let's get this out of the way and close a major!

Committed and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.