This is a sub-issue of #1910624: [META] Introduce and complete configuration schemas in all of core.

Problem/motivation

#1866610: Introduce Kwalify-inspired schema format for configuration introduced the idea of config schema. The changelog leads to (hopefully extensive) documentation on the format at http://drupal.org/node/1905070. While there are little cleanups planned for the format overall, the current format is a result of months of back and forths, so it should be perfectly fine to apply it more widely to core.

Proposed solution

Create a configuration schema for aggregator module.

Schema in place

Schema not yet in place
aggregator.settings.yml

Files: 
CommentFileSizeAuthor
#10 1912298-aggregator-schema-10.patch1.26 KBvijaycs85
PASSED: [[SimpleTest]]: [MySQL] 52,221 pass(es). View
#8 1912298-aggregator-schema-8.patch2.99 KBvijaycs85
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 1912298-aggregator-schema-8.patch. Unable to apply patch. See the log in the details link for more information. View
#7 2013-02-24_235314.png22.18 KBvijaycs85
#6 1912298-aggregator-schema-6.patch814 bytesvijaycs85
PASSED: [[SimpleTest]]: [MySQL] 50,587 pass(es). View
#6 1912298-diff-4-6.txt1.33 KBvijaycs85
#4 1912298-aggregator-schema-4.patch882 bytesvijaycs85
FAILED: [[SimpleTest]]: [MySQL] 48,362 pass(es), 36 fail(s), and 4 exception(s). View
#4 1912298-diff-3-4.txt1.34 KBvijaycs85
#3 1912298-aggregator-schema-3.patch824 bytesvijaycs85
FAILED: [[SimpleTest]]: [MySQL] 48,807 pass(es), 35 fail(s), and 4 exception(s). View

Comments

heyrocker’s picture

Gábor Hojtsy’s picture

Tag for new config schema board.

vijaycs85’s picture

Status: Active » Needs review
FileSize
824 bytes
FAILED: [[SimpleTest]]: [MySQL] 48,807 pass(es), 35 fail(s), and 4 exception(s). View

Adding schema file.

vijaycs85’s picture

FileSize
1.34 KB
882 bytes
FAILED: [[SimpleTest]]: [MySQL] 48,362 pass(es), 36 fail(s), and 4 exception(s). View

Fixing mapping element error.

Status: Needs review » Needs work

The last submitted patch, 1912298-aggregator-schema-4.patch, failed testing.

vijaycs85’s picture

Status: Needs work » Needs review
FileSize
1.33 KB
814 bytes
PASSED: [[SimpleTest]]: [MySQL] 50,587 pass(es). View

Updating space issue on "mapping"...

vijaycs85’s picture

FileSize
22.18 KB

Updated code style and verified with config_inspector

2013-02-24_235314.png

vijaycs85’s picture

FileSize
2.99 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 1912298-aggregator-schema-8.patch. Unable to apply patch. See the log in the details link for more information. View

Updating patch now...

Status: Needs review » Needs work

The last submitted patch, 1912298-aggregator-schema-8.patch, failed testing.

vijaycs85’s picture

Status: Needs work » Needs review
FileSize
1.26 KB
PASSED: [[SimpleTest]]: [MySQL] 52,221 pass(es). View

got additional commits that are not related to this issue in #8. Updating the right one now...

vijaycs85’s picture

Still green and valid - Ready for review :)

sandipmkhairnar’s picture

I have reviewed patch and its working for me.

tim-e’s picture

Status: Needs review » Reviewed & tested by the community

Looking good to me

webchick’s picture

Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.