Problem: Empty RDF tags are printed:

// Add RDF type and about URI.
  if (module_exists('rdf')) {
    $variables['attributes_array']['about'] = empty($uri['path']) ? NULL: url($uri['path']);
    $variables['attributes_array']['typeof'] = empty($entity->rdf_mapping['rdftype']) ? NULL : $entity->rdf_mapping['rdftype'];
  }

Solution: Do not set these at all when the values are NULL.

CommentFileSizeAuthor
#6 1910596-markup_validation_with_rdf-6.patch791 bytesytsurk
#4 markup_validation-1910596-4.patch757 bytesytsurk
#3 markup_validation-1910596-3.patch752 bytesytsurk

Comments

ytsurk’s picture

ytsurk
Location Switzerland
commented
Issue summary: View changes

changed php to code

ytsurk’s picture

ytsurk
Location Switzerland
commented
Issue summary: View changes

clarification

ytsurk’s picture

ytsurk
Location Switzerland
commented
Title: markup issue: double class attribute » markup issues: w3c validation
ytsurk’s picture

ytsurk
Location Switzerland
commented

the doubled class attribute (1) is caused by the omega theme ...
#1911204: class attribute of entity wrapper div is printed twice

/**
 * Implements hook_preprocess().
 */
function alpha_preprocess(&$vars, $hook) {
  $vars['attributes_array']['class'] = $vars['classes_array'];
  
  alpha_invoke('preprocess', $hook, $vars);
}

thx to @berdir

RDF still should be fixed

ytsurk’s picture

ytsurk
Location Switzerland
commented
Status: Active » Needs review
StatusFileSize
new markup_validation-1910596-3.patch752 bytes

here the patch, setting the properties only if !empty, removed the NULL setter.

ytsurk’s picture

ytsurk
Location Switzerland
commented
StatusFileSize
new markup_validation-1910596-4.patch757 bytes

sorry - missed the url() method

ytsurk’s picture

ytsurk
Location Switzerland
commented
Issue summary: View changes

enhanced

chris matthews’s picture

chris matthews commented
Version: 7.x-1.0-rc3 » 7.x-1.x-dev
Issue summary: View changes
Status: Needs review » Needs work
Issue tags: +Needs reroll

The 6 year old patch in #4 to entity.module does not apply to the latest entity 7.x-1.x-dev.

Checking patch entity.module...
error: while searching for:

  // Add RDF type and about URI.
  if (module_exists('rdf')) {
    $variables['attributes_array']['about'] = empty($uri['path']) ? NULL: url($uri['path']);
    $variables['attributes_array']['typeof'] = empty($entity->rdf_mapping['rdftype']) ? NULL : $entity->rdf_mapping['rdftype'];
  }

  // Add suggestions.

error: patch failed: entity.module:1055
error: entity.module: patch does not apply
ytsurk’s picture

ytsurk
Location Switzerland
commented
Status: Needs work » Needs review
Issue tags: -Needs reroll
StatusFileSize
new 1910596-markup_validation_with_rdf-6.patch791 bytes

Here the re-rolled patch.

ytsurk’s picture

ytsurk
Location Switzerland
commented
Issue summary: View changes
liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

Looks good.

  • TR committed 1c3aaa4 on 7.x-1.x 
    Issue #1910596 by ytsurk: markup issues: w3c validation
tr’s picture

tr commented
Status: Reviewed & tested by the community » Fixed

Committed #6. Thank you for your persistence @ytsurk!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.