Currently it's string which kills some important use cases.

CommentFileSizeAuthor
#2 0001-Fixed-1910126-Line-item-ID-Views-integration-should-.patch1.17 KBgeek-merlin

Comments

rszrama’s picture

rszrama commented
Status: Active » Postponed (maintainer needs more info)

As an argument it is; I see that for the filter it's string, but is it also for the sort? What use cases are you talking about?

geek-merlin’s picture

geek-merlin
Primary language German
Location Freiburg, Germany
commented
Status: Postponed (maintainer needs more info) » Reviewed & tested by the community
StatusFileSize
new 0001-Fixed-1910126-Line-item-ID-Views-integration-should-.patch1.17 KB

Patch flying in.
It's trivial and working in production, so daring to rtbc (maintainer may feel free to bump back if disagree).

geek-merlin’s picture

geek-merlin
Primary language German
Location Freiburg, Germany
commented

ah, ok - our posts had a race condition.

use cases / problems:
* filter "line item id <99" is not possible
* click sort is not numeric (1,15,2,...)

for me the filter thing was a real showstopper, the other a nice side effect.

(as of sort: sort happens in the db, so a sort handler is not typed. db knows its fields.)

rszrama’s picture

rszrama commented

Do you have the same issue then with the customer profile ID, order ID, and product ID, since their handlers extend views_handler_field instead of views_handler_numeric? Though looking at the core entity Views handlers, they also extend views_handler_field. Maybe it's not an issue for them?

rszrama’s picture

rszrama commented
Status: Reviewed & tested by the community » Fixed

In the absence of feedback, I'll commit this as is, since I haven't heard of problems with the other IDs. Also, I checked, and the payment transaction Views integration already used views_handler_field_numeric.

Commit: http://drupalcode.org/project/commerce.git/commitdiff/7ad17bc

geek-merlin’s picture

geek-merlin
Primary language German
Location Freiburg, Germany
commented

> Do you have the same issue then with the customer profile ID, order ID, and product ID...?
order id really? can't believe i didn't bump into that.
if they are not numeric, i'll fix that as soon as i bump into it.

;-)

rszrama’s picture

rszrama commented

The filter is numeric, it's just the field handler itself that extends a different base field. But if it hasn't been an issue, I doubt it's an issue. As I said, we're following the same pattern for those entity ID fields as core uses.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.