Raising the PHP-bar is not a nice thing. Lots of sites depend on 5.2.
You already mention this in below code. It that the only location for PHP5.3?
/**
* @TODO Compatible with PHP 5.3 and more only. Find a way for 5.2 compatibility.
*/
function _taxonomy_menu_flatten_form_settings($settings) {
$flatten = array();
array_walk_recursive($settings, function($a, $b) use (&$flatten) { $flatten[$b] = $a; });
return $flatten;
}| Comment | File | Size | Author |
|---|---|---|---|
| #5 | taxonomy_menu_1908974_5_PHP53.patch | 1.41 KB | johnv |
| #2 | taxonomy_menu_1908974_2_PHP53.patch | 1.05 KB | johnv |
Comments
Comment #1
hles commentedYes this is the only location. It needs to be rewritten for PHP 5.2 before releasing the final 2.0 version. PHP version should be removed from .info file once this is done.
Comment #2
johnvSee attached patch.
Line numbers are not correct, due to the other patch I am working on.
Comment #3
hles commentedThank you johnv.
Some trailing white spaces, coding standards for comments and the PHP 5.3 requirement in .info file and this is good to go.
Comment #4
johnvAny more details on the comments?
Comment #5
johnvComment #6
hles commentedThank you ! I'll commit this ASAP.
Comment #7
hles commentedCommitted with minor formatting changes 3755dfe. Thank you !