Problem/Motivation

The inline documentation is miss leading. see attached patch.

CommentFileSizeAuthor
#8 1906484-8-field-ui-field-settings-form.patch539 bytesdcam
field_ui_field_setting_form_submit_correction.patch577 bytessmiletrl

Comments

smiletrl’s picture

smiletrl commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, field_ui_field_setting_form_submit_correction.patch, failed testing.

aspilicious’s picture

aspilicious commented
Status: Needs work » Needs review

field_ui_field_setting_form_submit_correction.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, field_ui_field_setting_form_submit_correction.patch, failed testing.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Component: field system » documentation
Status: Needs work » Reviewed & tested by the community

Thanks for the patch! The test failures do not appear to be related to the patch. I'll wait to commit until we can get it to turn green though...

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented

field_ui_field_setting_form_submit_correction.patch queued for re-testing.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Version: 8.x-dev » 7.x-dev
Status: Reviewed & tested by the community » Patch (to be ported)

Thanks again -- committed to 8.x.

I think we need to do the same patch in 7.x, but the patch here doesn't apply, so it needs to be ported.

dcam’s picture

dcam commented
Status: Patch (to be ported) » Needs review
StatusFileSize
new 1906484-8-field-ui-field-settings-form.patch539 bytes

Backported the patch in the OP to D7.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented

This patch is fine... thanks!

I also noticed when I went to api.drupal.org and looked up this function that it says
@ingroups forms
and it should be
@ingroup forms
[no s on @ingroup]

Could we go back to d8 and fix that, then fix both problems in d7, or should we start another issue? I just checked with grep and this is the only place in core that has this typo.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Needs review » Fixed

I decided to commit the patch in #8 since I was doing some other 7.x commits anyway. Thanks!
Filed this follow-up issue for the @ingroups thing:
#1961832: Docs typo in field_ui.admin.inc

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.