Bootstrap causes an index undefined error if it is used on the overlay.

The error is
Notice: Undefined index: #primary in bootstrap_preprocess_page() (line 143 of C:\wamp\www\themes\bootstrap\template.php).

This is caused because on line 523 of overlay.module, the overlay unsets the #primary index (causing the error)

CommentFileSizeAuthor
#1 1902744.patch655 bytesTrentHouliston

Comments

TrentHouliston’s picture

TrentHouliston commented
Status: Active » Needs review
StatusFileSize
new 1902744.patch655 bytes

This patch fixes the problem

Status: Needs review » Needs work

The last submitted patch, 1902744.patch, failed testing.

TrentHouliston’s picture

TrentHouliston commented
Status: Needs work » Needs review

#1: 1902744.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, 1902744.patch, failed testing.

TrentHouliston’s picture

TrentHouliston commented

The test machine seems to be broken currently

TrentHouliston’s picture

TrentHouliston commented
Status: Needs work » Needs review

#1: 1902744.patch queued for re-testing.

natted’s picture

natted commented
Status: Needs review » Fixed

Hi Trent,

Thanks for submitting the patch.

I've committed a fix to 2.x-dev, slightly different to the patch you submitted. Reason for the adjustment is in case another module (other than overlay) acts similarly and unsets the #primary tabs.

Commit

If there are still any issues with overlay, let me know.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.