Form builder functions should be passed $form_state by reference. But one function in ctools_export_ui.class.php doesn't.

This bug is subtle and shows up in Stylizer where the listing of styles complains of a missing plugin and an unknown style base fore very style. The reason is that ctools_export_ui_list_form() is not getting the $form_state by reference. In stylizer's list_form method, the style bases are loaded and stashed in the form state. Since that is not passed by reference, they're not in the form state when the table rows are being set up.

CommentFileSizeAuthor
ctools_export_ui_form_state_reference.patch602 bytesAnonymous (not verified)

Comments

Anonymous’s picture

damienmckenna’s picture

Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

Sounds good.

japerry’s picture

Status: Reviewed & tested by the community » Fixed

simple bug. fixed.

  • japerry committed f539ced on 7.x-1.x authored by bangpound
    Issue #1901946 by bangpound: ctools_export_ui_list_form argument should...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.