Make use of the new remote language mapping feature from tmgmt core from http://drupal.org/node/1877418#comment-6997650

CommentFileSizeAuthor
#4 fix-remote-languages-method-1901890-4.patch2.32 KBberdir
#1 tmgmt_mygengo-remote_languages_mappings-1901890-1.patch4.28 KBblueminds

Comments

blueminds’s picture

blueminds commented
Status: Active » Needs review
StatusFileSize
new tmgmt_mygengo-remote_languages_mappings-1901890-1.patch4.28 KB

Implemented in attached patch

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Fixed

Commited and pushed.

issam.zeibak’s picture

issam.zeibak commented

Tested this on our side, this looks like a good fix.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Fixed » Needs review
StatusFileSize
new fix-remote-languages-method-1901890-4.patch2.32 KB

Well, that didn't work at all. It used the language pairs API method for the supported languages call (by looping over local languages) which was a) extremely slow as it does a call per source language and then groups it together b) was broken because the get language pairs method cached without checking the source language and c) would not actually work to look up not-matching source languages because it would not find matching language pairs ;)

There's a languages service callback, so we can simply use that...

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Fixed

Commited that.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Status: Closed (fixed) » Needs review

grimal queued 4: fix-remote-languages-method-1901890-4.patch for re-testing.

Status: Needs review » Needs work

The last submitted patch, 4: fix-remote-languages-method-1901890-4.patch, failed testing.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Issue summary: View changes
Status: Needs work » Closed (fixed)