Upon submission of a translation job the status in the column "Pending Translation" remains as is; which is not right.

Comments

berdir’s picture

Project: TMGMT Client » Translation Management Tool
Version: » 7.x-1.x-dev
Component: User interface » Source: Entity

Moving to the correct place.

jos doekbrijder’s picture

Component: Source: Entity » User interface
miro_dietiker’s picture

Component: User interface » Source: Entity

The place was absolutely right.

berdir’s picture

Status: Active » Needs review
StatusFileSize
new884 bytes

Components are not about what the user thinks is correct, it is about where it technically belongs. It doesn't matter if it's initially reported wrong but please don't "correct" it :)

miro_dietiker’s picture

Status: Needs review » Needs work

Looks fine. I guess we need a test for that as this is a critical element of the UI.

cgalli’s picture

When submitting a job for entity source translation (node with source language german), I get the following warning:

Notice: Array to string conversion in drupal_map_assoc() (line 2732 of /var/www/tmgmt/includes/common.inc).
Notice: Array to string conversion in drupal_map_assoc() (line 2732 of /var/www/tmgmt/includes/common.inc).

The source language in the job checkout is NOT set, although it should

Setting the source language manually, one can submit the job, but the source language is still not set and therefore the job not accessible.

Same problem?

cgalli’s picture

Status: Needs work » Needs review
StatusFileSize
new2.67 KB

Consistently use entity_language() to get source language of the entity

Status: Needs review » Needs work

The last submitted patch, tmgmt-missing-pending-translations-1900926-7.patch, failed testing.

berdir’s picture

Status: Needs work » Needs review
StatusFileSize
new5.42 KB

Re-rolled to use correct line endings (@cgalli, make sure to configure your IDE to use unix file endings) and added tests.

berdir’s picture

Status: Needs review » Fixed

Commited and pushed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.