The amout of results is not unified.
Node sources: 10
Entity sources: 20

At least these should be equal.

10 are not enough for real management.
admin/content has 50 results that might be a bit too much..?

Any UX suggesion?

CommentFileSizeAuthor
#4 tmgmt-1900924-unify-4.patch1.47 KBmiro_dietiker
#1 tmgmt_1900924_unify.patch467 bytesmiro_dietiker

Comments

miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented
Assigned: Unassigned » cgalli
StatusFileSize
new tmgmt_1900924_unify.patch467 bytes

This is what we have:

$ grep -R "10" . | grep per_page
./translators/tmgmt_local/views/tmgmt_local_manage_translate_task.view.inc:23:$handler->display->display_options['pager']['options']['items_per_page'] = '10';
./translators/tmgmt_local/views/tmgmt_local_task_overview.view.inc:23:$handler->display->display_options['pager']['options']['items_per_page'] = '10';
./translators/tmgmt_local/views/tmgmt_local_translate.view.inc:23:$handler->display->display_options['pager']['options']['items_per_page'] = '10';
./ui/views/tmgmt_ui_job_item_messages.view.inc:22:$handler->display->display_options['pager']['options']['items_per_page'] = '10';
./ui/views/tmgmt_ui_job_items.view.inc:22:$handler->display->display_options['pager']['options']['items_per_page'] = '10';
./ui/views/tmgmt_ui_job_messages.view.inc:22:$handler->display->display_options['pager']['options']['items_per_page'] = '10';
./ui/views/tmgmt_ui_job_overview.view.inc:22:$handler->display->display_options['pager']['options']['items_per_page'] = '10';

$ grep -Rn "20" . | grep Limit
./sources/entity/tmgmt_entity.ui.inc:17:  public $pagerLimit = 20;

Switching to 10 in the entity so things are uniform as a starting point.

However i don't like the result count at 10 - it's simply too less for real life cases.
Should we just switch to 50 from core admin/content as a starting point?

miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented
Status: Active » Needs review
cgalli’s picture

cgalli commented
Assigned: cgalli » miro_dietiker
Status: Needs review » Needs work

I think 25 is a good number. Gives a reasonable overview and can still fit on one page.

With 50 there is too much scrolling

miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented
Status: Needs work » Needs review
StatusFileSize
new tmgmt-1900924-unify-4.patch1.47 KB

The pager data was completely missing in the node source view export.

cgalli’s picture

cgalli commented
Status: Needs review » Reviewed & tested by the community

looking good

miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented
Status: Reviewed & tested by the community » Fixed

Committed, pushed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.