Add color legends to the entity source view

Added color legends to the help area, implemented for 'node sources' and 'entity sources'

The patch has not touched a windows editor so the endings should be ok...

Thanks!

There are quite a lot of views bulk operation changes in the export view. I assume that's because the version changed or something and not because you made any changes?

+++ b/ui/tmgmt_ui.moduleundefined
@@ -820,3 +820,43 @@ function tmgmt_ui_redirect_queue_dequeue() {
+ * Implements hook_help.
+ * @param $path
+ * @param $arg
+ * @return string

The @param and @return should be removed.

+++ b/ui/tmgmt_ui.moduleundefined
@@ -820,3 +820,43 @@ function tmgmt_ui_redirect_queue_dequeue() {
+
+function tmgmt_ui_help($path, $arg){

Unecessary empty line.

+++ b/ui/tmgmt_ui.moduleundefined
@@ -820,3 +820,43 @@ function tmgmt_ui_redirect_queue_dequeue() {
+  case 'admin/config/regional/tmgmt/entity':
+  case 'admin/config/regional/tmgmt/node':

As discussed, the problem with this is that the documentation for the entity and node modules is in the base module.

So if i18n finally adds a UI too, we will have to add it here as well.

Let's do this instead:
Move the code below into a helper function, something like tmgmt_ui_color_legend(), implement this hook for tmgmt_entity_ui and tmgmt_node_ui and call that function.

+++ b/ui/tmgmt_ui.moduleundefined
@@ -820,3 +820,43 @@ function tmgmt_ui_redirect_queue_dequeue() {
+        <div class="tmgmt-legend-title">Color Legend:</div>';

This part is not translatable.

+++ b/ui/tmgmt_ui.moduleundefined
@@ -820,3 +820,43 @@ function tmgmt_ui_redirect_queue_dequeue() {
+          $legend['color'] . '" title="Source language"><span></span></div>

The title here doesn't seem to make sense? And it isn't translatable, but I think we can just remove it.

Here we go again.

- Only removed the footer from the view
- split the hook_help into three parts as suggested
- corrected errors

Thanks, commited.

That was too fast then.

Yes. Suggestion: Make the css selector so specific that it only matches if it's placed in the region where we want it to be floated. Make sure that things don't break when help is moved into a sidebar or below the main content. Maybe even put the css into a .seven.css and only apply it when the active theme is seven.

The right floating happens only in theme seven and only in the content region

removed the title to save space

Added formatting for entity sources as well.

Load css files in color legend function

Replaces the path in #11

+++ b/ui/tmgmt_ui.moduleundefined
@@ -825,6 +825,13 @@ function tmgmt_ui_redirect_queue_dequeue() {
+  global $theme;
+  if($theme == 'seven')
+    drupal_add_css(drupal_get_path('module', 'tmgmt_ui') . '/css/tmgmt_ui.admin.seven.css');

globals are usually defined at the top of a function.

Missing a space after if and { }

fixed

#14: Add-color-legends-to-the-entity-source-view-1900916-14.patch queued for re-testing.

Thanks, committed with a few coding style fixes.