node reference with multiple values

What version of Solr are you using? I've encountered this with Solr 4. I've seen this happening with hierarchic taxonomy fields. Can you try latest dev version and see if it is resolved? (patched something about this problem last weekend)

apachesolr_nodereference_indexing_callback should probably check if the field is single valued and only allow 1 value if that is the case.

Could one of you tell me what is in the $field_info for your specific case?

function apachesolr_nodereference_indexing_callback($entity, $field_name, $index_key, array $field_info) {
 dsm($field_info);
  ....

I'm using 7.x-1.1 regularly and it seems 7.x-1.x-dev (downloaded today) introduces a bug on entity-reference to taxonomy terms. I have a field that is an entity-reference to an unlimited number of taxonomy terms of a particular vocabulary. The apachesolr status page for facets identifies the field as an ss_ field, but it's attemted indexed as an sm_ field (which of course fails terribly on the solr-side). Solr 3.6 here, but it's really not a Solr problem.

I'll try to be more explicit on the nature of this bug when I have some time on my hands. For now I'll just have to "put it out there".

R

No time is no excuse, really. Just put a debug statement there and paste it here. :)

* apachesolr_entityreference_indexing_callback
* dd($field_info);

Gives:

(Note the multiple field; here it holds nothing. The stable version holds "1")

Array
(
    [indexing_callback] => apachesolr_entityreference_indexing_callback
    [map callback] => apachesolr_entityreference_facet_map_callback
    [index_type] => string
    [facets] => 1
    [query types] => Array
        (
            [0] => term
        )

    [facet missing allowed] => 1
    [dependency plugins] => Array
        (
            [0] => bundle
            [1] => role
        )

    [name callback] => 
    [hierarchy callback] => 
    [facet mincount allowed] => 
    [multiple] => 
    [field] => Array
        (
            [entity_types] => Array
                (
                )

            [foreign keys] => Array
                (
                    [node] => Array
                        (
                            [columns] => Array
                                (
                                    [target_id] => nid
                                )

                            [table] => node
                        )

                )

            [indexes] => Array
                (
                    [target_id] => Array
                        (
                            [0] => target_id
                        )

                )

            [settings] => Array
                (
                    [handler] => base
                    [handler_settings] => Array
                        (
                            [behaviors] => Array
                                (
                                    [views-select-list] => Array
                                        (
                                            [status] => 0
                                        )

                                )

                            [sort] => Array
                                (
                                    [type] => none
                                )

                            [target_bundles] => Array
                                (
                                    [nav_styrk] => nav_styrk
                                )

                        )

                    [target_type] => taxonomy_term
                )

            [translatable] => 0
            [storage] => Array
                (
                    [type] => field_sql_storage
                    [settings] => Array
                        (
                        )

                    [module] => field_sql_storage
                    [active] => 1
                    [details] => Array
                        (
                            [sql] => Array
                                (
                                    [FIELD_LOAD_CURRENT] => Array
                                        (
                                            [field_data_field_nav_styrk] => Array
                                                (
                                                    [target_id] => field_nav_styrk_target_id
                                                )

                                        )

                                    [FIELD_LOAD_REVISION] => Array
                                        (
                                            [field_revision_field_nav_styrk] => Array
                                                (
                                                    [target_id] => field_nav_styrk_target_id
                                                )

                                        )

                                )

                        )

                )

            [id] => 115
            [field_name] => field_nav_styrk
            [type] => entityreference
            [module] => entityreference
            [active] => 1
            [locked] => 0
            [cardinality] => -1
            [deleted] => 0
            [columns] => Array
                (
                    [target_id] => Array
                        (
                            [description] => The id of the target entity.
                            [type] => int
                            [unsigned] => 1
                            [not null] => 1
                        )

                )

            [bundles] => Array
                (
                    [node] => Array
                        (
                            [0] => utdanningsbeskrivelse
                            [1] => yrke
                        )

                )

        )

    [name] => field_nav_styrk
    [module_name] => Entity Reference
    [display_name] => Nav kategori
    [bundles] => Array
        (
            [0] => utdanningsbeskrivelse
            [1] => yrke
        )

)

So 'multiple' seems to be false, apachesolr correctly gives it a singular field. I assume that the assignment of entityreference keys is done incorrectly somehow.

Could you also do a debug of the apachesolr_entity_fields();function? Perhaps we have to force all reference fields to be multiple in any case?

In apachesolr_entity_fields() there is:

 $row['field'] = $field;

Append immediately after:

if ($row['field']['cardinality'] !== 0 && $row['field']['cardinality'] !== 1) {
  $row['multiple'] = TRUE;
}

Solves it for me. Maybe the !==0 is redundant. In any case, cardinality -1 or >1 are the multiples.

Interesting, could you make a patch? And add some documentation about the cardinality field.

eg.: cardinality (integer): The number of values the field can hold. Legal values are any positive integer or FIELD_CARDINALITY_UNLIMITED.
http://api.drupal.org/api/drupal/modules%21field%21field.module/group/fi...

So it's only when the value == 1, we should set a field to single. -1 is unlimited and anything else means multiple. I'm not sure what 0 does. Also, we might want to rename multiple throughout the codebase to cardinality to sync more with D7?

See attached patch.

+++ b/apachesolr.moduleundefined
@@ -2017,6 +2017,11 @@ function apachesolr_entity_fields($entity_type = 'node') {
+        if ($row['field']['cardinality'] !== 1) {

We also want to check if the field is set, so you can do an isset($field['cardinality]) && $field['cardinality'] !== 1

Attached patch v2.

I assumed it must hold positive integer or FIELD_CARDINALITY_UNLIMITED, but better safe than sorry; guess an isset doesn't "cost" all that much.

Is there a reason to use !== instead of just !=? Are we sure it will never be '1'?

Setting to needs review to get picked up by automated tests.

I'm not sure of that, But if a '1' is found, maybe it should be fixed by the code that violates the documented behaviour?

R

You can just use !=, makes it less strict, but more certain that even custom code will be picked up.

Something similar here:

ERROR: [66e11o/node/3] multiple values encountered for non multiValued field
ss_field_testimonial

In our case, field_testimonial is a multi value entity reference on a node.

#15 solved the issue.

Also confirming #15 seems to have fixed the issue for us.

Been bitten by this as well. Rerolled for 80 chars limit and removed the isset(). @nick, field api adds defaults, also for cardinality (defaults to 1), so the property is always set. Still RTBC.

BAH

Not sure if it needs backport, but marking as such until someone confirms. Committed to 7.x-1.x

Attached is a patch for a backport to 6.x-3.x.

Drupal 6 does not have the cardinality config, only multiple. So due to that it is not applicable and I am going to close this issue.