Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Currently the login button in the twitter_login module is added to the form as an item list directly inserted using #markup. This makes it uneditable anywhere down the line. The code where this happens is line 106 of twitter_login.module:
$form['twitter_signin'] = array(
'#markup' => theme('item_list', array('items' => $items)),
);
I am attaching a patch to turn this into a render array:
$form['twitter_signin'] = array(
'#theme' => 'item_list',
'#items' => $items,
'#attributes' => array('class' => array('twitter_signin')),
);
Comment | File | Size | Author |
---|---|---|---|
#1 | twitter-make_twitter_login_item_into_render_array-1899594-1.patch | 667 bytes | Jaypan |
Comments
Comment #1
Jaypan CreditAttribution: Jaypan commentedPatch attached.
Comment #2
Jaypan CreditAttribution: Jaypan commentedComment #3
13rac1 CreditAttribution: 13rac1 commentedApplies cleanly against 7.x-5.x. Looks good.
Comment #4
DamienMcKennaTriggering the testbot.
Comment #7
DamienMcKennaCommitted to both the 7.x-5.x and 7.x-6.x branches.