Currently the login button in the twitter_login module is added to the form as an item list directly inserted using #markup. This makes it uneditable anywhere down the line. The code where this happens is line 106 of twitter_login.module:

    $form['twitter_signin'] = array(
      '#markup' => theme('item_list', array('items' => $items)),
    );

I am attaching a patch to turn this into a render array:

    $form['twitter_signin'] = array(
      '#theme' => 'item_list',
      '#items' => $items,
      '#attributes' => array('class' => array('twitter_signin')),
    );
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Jaypan’s picture

Jaypan’s picture

Status: Active » Needs review
13rac1’s picture

Version: 7.x-3.3 » 7.x-5.x-dev
Status: Needs review » Reviewed & tested by the community

Applies cleanly against 7.x-5.x. Looks good.

DamienMcKenna’s picture

Issue summary: View changes
Status: Reviewed & tested by the community » Needs review
Parent issue: » #2402307: Plan for Twitter v7.x-5.9 release

Triggering the testbot.

  • DamienMcKenna committed a8f932a on 7.x-5.x authored by Jaypan
    Issue #1899594 by Jaypan: Change login element into a render array.
    

DamienMcKenna’s picture

Status: Needs review » Fixed

Committed to both the 7.x-5.x and 7.x-6.x branches.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.