Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
I do also. I have not been able to figure out what is causing it.
I would not call myself a JS expert but I looked at the JS code in the module. The same function is called when the next button is clicked as is called when a song ends.
Drupal.jplayer.next(wrapper, player) which calls Drupal.jplayer.setFiles(wrapper, player, index, play) which finally calls $(player).jPlayer('play');
The song will automatically play when the next button is clicked, but not when the song ends, although a trace (Firebug) "looks" like everything should work. Since the JS correctly "changes" the song for both the next button and the song end, I looked at the player to see if it was passed correctly. It *looked* ok too. (Apologies if I overlooked something--I am a PHP person!)
I have the same issue when I create a content type with a multi-value audio file field. When repeat is set to "All" a song will not automatically play after the previous song ends, although the next song will be set as the current song.
Renaming the issue because it doesn't seem to be related to Views. (I am using a content type with a multi-value audio file field and am not using it with Views.)
I found that jplayer.theme.inc in 7.x-2.0-beta1+10-dev version of jPlayer module is missing one line in preprocess function for jplayer.tpl.php when displaying a view as a playlist.
Missing line is: 'continuous' => $vars['settings']['continuous'],
So player settings array in template_preprocess_jplayer_view_playlist should be:
silurius: Don't forget it is missing in function template_preprocess_jplayer_view_playlist(which is why continuous play didn't work in views), not in template_preprocess_jplayer.
Comments
Comment #1
ghosts CreditAttribution: ghosts commentedI do also. I have not been able to figure out what is causing it.
I would not call myself a JS expert but I looked at the JS code in the module. The same function is called when the next button is clicked as is called when a song ends.
Drupal.jplayer.next(wrapper, player)
which callsDrupal.jplayer.setFiles(wrapper, player, index, play)
which finally calls$(player).jPlayer('play');
The song will automatically play when the next button is clicked, but not when the song ends, although a trace (Firebug) "looks" like everything should work. Since the JS correctly "changes" the song for both the next button and the song end, I looked at the player to see if it was passed correctly. It *looked* ok too. (Apologies if I overlooked something--I am a PHP person!)
Comment #2
ghosts CreditAttribution: ghosts commentedUpdate: It's not confined to views.
I have the same issue when I create a content type with a multi-value audio file field. When repeat is set to "All" a song will not automatically play after the previous song ends, although the next song will be set as the current song.
Comment #3
ghosts CreditAttribution: ghosts commentedcontinuous play works fine in
continuous play does not work in
Comment #4
silurius CreditAttribution: silurius commentedI'm seeing this in 7.x-2.0-beta1+10-dev as well. Anyone interested in picking this issue up?
Comment #5
silurius CreditAttribution: silurius commentedRenaming the issue because it doesn't seem to be related to Views. (I am using a content type with a multi-value audio file field and am not using it with Views.)
Comment #6
tekket CreditAttribution: tekket commentedI found that jplayer.theme.inc in 7.x-2.0-beta1+10-dev version of jPlayer module is missing one line in preprocess function for jplayer.tpl.php when displaying a view as a playlist.
Missing line is:
'continuous' => $vars['settings']['continuous'],
So player settings array in template_preprocess_jplayer_view_playlist should be:
Comment #7
silurius CreditAttribution: silurius commentedHuh, my version of that same .inc (same beta version I think) was not missing that line.
Comment #8
tekket CreditAttribution: tekket commentedsilurius: Don't forget it is missing in function template_preprocess_jplayer_view_playlist(which is why continuous play didn't work in views), not in template_preprocess_jplayer.
Comment #9
tr33m4n CreditAttribution: tr33m4n commentedThat worked for me, cheers bud
Comment #10
Yogesh Kushwaha CreditAttribution: Yogesh Kushwaha commented#6 works for me
Thanks
Comment #11
markie CreditAttribution: markie commentedHmmm I wonder how that got removed. I have added it back and will be committing it to dev today.
@tekket++
Comment #13
markie CreditAttribution: markie commentedAdded continuous back to theme. Pushed to dev.