Support from Acquia helps fund testing for Drupal Acquia logo

Comments

c4rl’s picture

Issue tags: +Twig

Tagging

tim.plunkett’s picture

Issue tags: +VDC

Tagging.

joelpittet’s picture

Assigned: Unassigned » joelpittet
joelpittet’s picture

Status: Active » Needs review
FileSize
45.67 KB

First run at this one, could use a hand with a re-roll for the @todos in the preprocessors and twig templates. Also a general review would be nice as well.

all the unset()'s were are to mimic what drupal_render does by removing form elements as they are rendered
added @todo Refactor when http://drupal.org/node/1920886 is resolved.

joelpittet’s picture

that one will fail, this little guy will hopefully fix it.

Status: Needs review » Needs work

The last submitted patch, drupal-twig-views-ui-1898472-5.patch, failed testing.

joelpittet’s picture

Status: Needs work » Needs review
FileSize
2.5 KB
46.14 KB

Added some checks for all those widget, value, etc missing references...

Status: Needs review » Needs work

The last submitted patch, drupal-twig-views-ui-1898472-7.patch, failed testing.

duellj’s picture

Status: Needs work » Needs review
FileSize
8.31 KB
46.89 KB

Ok, I think I fixed most of the failing tests. One of the problems was that columns that are render arrays need to placed in 'data' keys. I also changed some hardcoded links to render arrays.

This should be set back to needs work after testbot checks it out, since there's still some doc updates that need to happen.

Status: Needs review » Needs work
Issue tags: -Twig, -VDC

The last submitted patch, 1898472-9-twig-views-ui.patch, failed testing.

duellj’s picture

Status: Needs work » Needs review
Issue tags: +Twig, +VDC

#9: 1898472-9-twig-views-ui.patch queued for re-testing.

joelpittet’s picture

Status: Needs review » Needs work

Thanks a bunch @duellj I didn't think I would need to have to change those other table cell fields as well. And thanks for the link conversions too!

Needs docblock review and cleanup

joelpittet’s picture

Assigned: joelpittet » Unassigned
Status: Needs work » Needs review
FileSize
10.72 KB
47.17 KB

@duellj, fixed a typo of '#theme' => '#link' and a left over dpm().

Also, did some of the doc todos.
Could use a hand finishing off the doc @todos

damiankloip’s picture

I'm not being funny, but we didn't say we wanted separate issues for all of these? or was that for the actual templates, I'm not sure.

Anyway, see #1929064: [Change notice] Refactor views_ui_rearrange_form to remove theme function for table render, as this will affect this a little. We will be removing some stuff there.

star-szr’s picture

@damiankloip - we could certainly split this up, please let us know what you'd like us to do; we're trying to get all of core converted by mid-April :)

star-szr’s picture

Title: Convert view_ui module to Twig » Convert views_ui module to Twig

Looks like we already have some sub-issues here (two that migrated from the Twig sandbox), so I guess I'm leaning towards splitting this up:

#1843774: Convert views/views_ui/templates/views-ui-display-tab-setting.tpl.php to Twig
#1843772: Convert views/views_ui/templates/views-ui-display-tab-bucket.tpl.php to Twig
#1918648: Convert theme_views_ui_style_plugin_table to Twig

Also if I'm not mistaken these two declarations can be removed from views_ui_theme(), I don't see them used anywhere:
theme_views_tabset()
theme_views_tab()

star-szr’s picture

Status: Needs review » Needs work

Found one more, I think we should just split the patch up and make this issue a meta.

#1915026: Convert theme_views_ui_container to Twig

dawehner’s picture

@Cottser
You are absolute right, this is from D6, though I remember that I had opened an issue for it. If you don't find it, don't mind fill your own.

star-szr’s picture

Title: Convert views_ui module to Twig » [meta] Convert views_ui module to Twig
Status: Needs work » Active

Okay, this is a meta now. @joelpittet said he could split up the patch and add to the sub-issues.

star-szr’s picture

Issue summary: View changes

Converting to meta issue

star-szr’s picture

Issue summary: View changes

Listifying

star-szr’s picture

Issue summary: View changes

Update for theme_views_ui_rearrange_form()

joelpittet’s picture

Issue summary: View changes

re-order

star-szr’s picture

As discussed with @dawehner we will remove @ingroup views_templates from all Views and Views UI .html.twig templates. If you are working on patches on any of the sub-issues that have this line in the template(s) it would be a huge help if you can reroll to remove that line. Thanks!

star-szr’s picture

Issue summary: View changes

Remove theme_views_tabset()

star-szr’s picture

Issue summary: View changes

Remove issues that are no longer Twig conversions (cleanup, #type table conversions, etc)

joelpittet’s picture

Status: Active » Closed (duplicate)
joelpittet’s picture

Issue summary: View changes

Add assignment dealie (@ signs)