Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Task
Use Twig instead of PHPTemplate
Remaining
- Replace all tpl.php files with .html.twig equivalents
- Replace all theme functions with .html.twig equivalent templates
- Add new preprocess functions for the .html.twig equivalent templates
- Update all hook_theme definitions
Related Issues
#1898472: [meta] Convert views_ui module to Twig
#1757550: [Meta] Convert core theme functions to Twig templates
Comment | File | Size | Author |
---|---|---|---|
#49 | 1963988-49-twig-views-ui-view-preview-section.patch | 3.16 KB | joelpittet |
#49 | interdiff.txt | 722 bytes | joelpittet |
#47 | interdiff.txt | 1.69 KB | joelpittet |
#47 | 1963988-47-twig-views-ui-view-preview-section.patch | 3.16 KB | joelpittet |
#41 | 1963988-41-twig-views-ui-view-preview-section.patch | 3.19 KB | joelpittet |
Comments
Comment #1
star-szrTagging.
Comment #2
joelpittetsplit from meta
Comment #3
thedavidmeister CreditAttribution: thedavidmeister commentedReview for #2:
+ * - content: The content for this seciton preview.
"section"
That's all that I can see for coding style.
This issue needs manual testing steps in the issue summary and for somebody to follow the steps and test the markup.
Comment #4
star-szrCreating a revised patch and interdiff based on #3 would be a good novice task, tagging.
If you'd like to work on this, please assign the issue to yourself. If you get stuck, drop by #drupal-twig on IRC or post your questions here. Thanks!
Comment #5
thedavidmeister CreditAttribution: thedavidmeister commentedManual testing is also a good novice task!
Comment #6
joelpittetCleanup from #3 thanks @thedavidmeister and @Cottser
Ready for manual testing.
Comment #7
kbasarab CreditAttribution: kbasarab commentedManual testing done as a group at Florida Drupalcamp 2013 core mentoring code sprint.
Comment #8
thedavidmeister CreditAttribution: thedavidmeister commentedComment #9
dawehnerNot sure whether we want to commit a patch with a @todo in there :)
Comment #10
thedavidmeister CreditAttribution: thedavidmeister commentedLots of the current patches have @todo for documentation of cryptic variables, especially those in the Views conversion.
Comment #11
thedavidmeister CreditAttribution: thedavidmeister commentedComment #12
dawehnerAh I see, there is an explicit tag for @todo cleanups.
Comment #13
joelpittet@dawehner if you know, or anybody from VDC knows just one of those @todo pieces, please let us know and we will plop them in there.
Comment #14
dawehnerThe section which is rendered (for example title, rows or pager).
The human readable title of the section.
Comment #15
thedavidmeister CreditAttribution: thedavidmeister commentedComment #16
joelpittetThanks @dawehner! Rolled them in from #14
Realized we don't need 'title', so moved the wording over to the twig file and removed that param documentation because it wasn't really a param. Tweaked the wording a bit on the first one too, I'm sure it will be changed again but hopefully that helps.
Comment #17
joelpittetremove tags
Comment #18
thedavidmeister CreditAttribution: thedavidmeister commented#16 - woooah, @joelpittet looks like you didn't pull latest 8.x before you started work. There's like 500kb of regression in that last patch. Can we please get a re-roll?
Comment #19
joelpittetWhoops, thanks @thedavidmeister. Forgot to rebase against origin/8.x
Comment #20
dawehnerGreat!
Comment #21
Fabianx CreditAttribution: Fabianx commented#19: 1963988-19-twig-views-ui-view-preview-section.patch queued for re-testing.
Comment #23
star-szrTagging for reroll, the Views UI module got moved to core/modules in #1820414: CHANGE NOTICE: Move views_ui.module directly into /core/modules/.
Comment #24
chrisjlee CreditAttribution: chrisjlee commentedreroll plus change applied as per #23.
Comment #25
dlu CreditAttribution: dlu commentedWorking on it in PDX.
Comment #26
Gaelan CreditAttribution: Gaelan commented@dlu Already rerolled. :)
Comment #27
Fabianx CreditAttribution: Fabianx commentedI think this is ready to fly. It was RTBCed by dawehner already, has been re-rolled, I re-reviewed the code and it looks good!
=> RTBC again, lets get this in.
Comment #28
Dries CreditAttribution: Dries commentedSadly, this patch no longer applies:
I'm going to ask for a re-test to make sure.
Comment #29
Dries CreditAttribution: Dries commented#24: 1963988-reroll-patch19-25.patch queued for re-testing.
Comment #31
star-szrOkay now it does need a reroll. Thanks @Dries!
Comment #32
Gaelan CreditAttribution: Gaelan commentedRerolling.
Comment #33
Gaelan CreditAttribution: Gaelan commentedRerolled.
Comment #34
Gaelan CreditAttribution: Gaelan commentedEDIT: Whoops, double post.
Comment #35
Gaelan CreditAttribution: Gaelan commentedI think I messed this up. About to try again.
Comment #36
Gaelan CreditAttribution: Gaelan commentedRererolled.
Comment #38
star-szrThanks @Gaelan!
Back to RTBC per #27 as long as testbot agrees.
Comment #39
alexpottFor reasons I can not explain... I can not download the patch in #33 I get a page not found :( http://drupal.org/files/views_ui.1963988.33.theme_preview_section_twig_0...
Any chance of uploading again?
Comment #40
drupalninja99 CreditAttribution: drupalninja99 commentedI also get a page not found
Comment #41
joelpittetRe-roll from #24 the only difference is there from #33 that I guess is what @Gaelan was intending to post in #36 was the removal of the preprocess function.
Comment #43
drupalninja99 CreditAttribution: drupalninja99 commented#41: 1963988-41-twig-views-ui-view-preview-section.patch queued for re-testing.
Comment #44
drupalninja99 CreditAttribution: drupalninja99 commentedI ran the test that failed locally with no errors, going to try again.
Comment #45
dawehnerAfaik we remove all of these now.
Comment #46
jenlamptontagging
Comment #47
joelpittetCleanup docs from #45 and V to v.
Comment #48
dawehner... missing v in "views" :)
Comment #49
joelpittetWhoops, well maybe we should call them `iews` from now on:P Then it won't be confused with the concept of a view and view modes:P
Comment #50
dawehnerHa!
Comment #51
thedavidmeister CreditAttribution: thedavidmeister commented@joelpittet - I vote they should be called Iews (capital I) ;)
Comment #52
alexpottCommitted 7d267ff and pushed to 8.x. Thanks!
Comment #53.0
(not verified) CreditAttribution: commentedremove sandbox link