Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
To make the gap between Search API and Apache Solr smaller we've been working on common configs.
This patch is the result of all of that work. Please review, will be committing this very shortly
Comment | File | Size | Author |
---|---|---|---|
#14 | 1896470-14.patch | 6.34 KB | jantoine |
#12 | 1896470-12.patch | 7.71 KB | jantoine |
#9 | 1896470-9.patch | 656 bytes | Nick_vh |
#8 | 1896470-8.patch | 660 bytes | Nick_vh |
#6 | 1896470_highlighting.patch | 372 bytes | mkalkbrenner |
Comments
Comment #1
Nick_vhComment #2
Nick_vhComment #3
Nick_vhMaking sure that the live indexing tests make full use of these schemas
Comment #4
Nick_vhCommitted, the live indexing test is still borked for 3.6 but it's a fault of Solr, not Drupal (does not remove the spellchecker folder)
Comment #5
Nick_vhComment #6
mkalkbrennerSince #3 has been committed highlighting is not working anymore for solr 3.x, because
<str name="hl">true</str>
has been removed from solrconfig.xml.I attached a patch that enables highlighting in the default parameters, which still works for solr 1.x, too.
Comment #7
mkalkbrennerComment #8
Nick_vhAdding back default params that we lost when implementing the common schema
Comment #9
Nick_vhStupid trailing space
Comment #10
Nick_vhBoth patches should be committed to 6.x-3.x
Comment #11
pwolanin CreditAttribution: pwolanin commentedcan't directly apply the 1st patch ... am I missing an intermediate change?
2 out of 2 hunks ignored -- saving rejects to file solr-conf/solr-4.x/solrconfig.xml.rej
Comment #12
jantoine CreditAttribution: jantoine commentedAll of the configuration changes contained in the two patches that were committed from this thread to the 7.x-1.x branch have already been committed to the 6.x-3.x branch as well. Attached is a patch that contains all other changes.
With this patch, I am still seeing a bizzare issue in the 6.x-3.x branch and not the 7.x-1.x branch where snippets for search results are showing fine when a query string is not set, but snippets are missing when a query string is set. I pinned this issue down to the query parameters being different which lead me to this issue. Now that I have applied the attached patch and my query parameters are the same, I am at a loss as to why I am seeing different behavior between 6.x-3.x and 7.x-1.x. I am going to continue investingating and hope to provide a fix, but any direction would be helpful.
Comment #13
pwolanin CreditAttribution: pwolanin commentedthis change looks wrong:
if we did that in 7.x, it should be reverted.
Comment #14
jantoine CreditAttribution: jantoine commented@pwolanin,
This was done in the 7.x-1.x branch, but I beleive it was reverted. An updated patch is attached.
Comment #15
pwolanin CreditAttribution: pwolanin commentedI just committed missing piece to 6.x-3.x - this might be done now.
Comment #16
mkalkbrenner