Hi, I just installed the latest version and spent quite a while trying to work out why I couldn't get the taxonomy term options to appear in the menu item form. The cause appears to be that the entity type is 'taxonomy_term' but the token type is 'term'. This bug seems to have been caused by your refactoring to remove the type-specific plugins.

(I took a look at the original plugin in the hope that I could just drop it back into the plugins directory but the code doesn't seem to solve my problem, which is to be able to extract a taxonomy term from the url in a more general manner. Ideally I'd like panels integration, but that seems to be somewhat tricky.)

CommentFileSizeAuthor
#2 entity_token_type-1895628-2.patch3.97 KBmalberts
#1 entity_token_type-1895628-1.patch4.09 KBmalberts
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

malberts’s picture

malberts CreditAttribution: malberts commented
Title: Change to plugin structure makes taxonomy plugin unavailable » Entity type does not necessarily match token type
Version: 7.x-1.0-beta3 » 7.x-1.x-dev
Status: Active » Needs review
FileSize
entity_token_type-1895628-1.patch4.09 KB

Changed 2 things:
1. The original code assumes entity type = token type.
2. The context loader plugin assumes the entity path has this pattern: [something]/[entity_id]

I'm not 100% happy with (2) because I couldn't find any cleaner way to get the entity represented by the URL. However, they way I have it now it should work for things like "taxonomy/term/123" and also on a View page, for example "taxonomy/term/123/news".

I noticed that the beta version is newer than the dev version, however the patch applied cleanly locally on both dev and beta-5.

malberts’s picture

malberts CreditAttribution: malberts commented
FileSize
entity_token_type-1895628-2.patch3.97 KB

Previous patch's URL sniffing died when editing menu links.

DevElCuy’s picture

DevElCuy CreditAttribution: DevElCuy commented

Code looks great but I would like to see passing tests. Nice opportunity for somebody that would like to showcase their simpletest skills in a popular module ;)

DevElCuy’s picture

DevElCuy CreditAttribution: DevElCuy commented
Status: Needs review » Needs work
DevElCuy’s picture

DevElCuy CreditAttribution: DevElCuy commented
Issue summary: View changes

OK, nobody wants to write a patch... if the patch applies I'll commit it as is!

DevElCuy’s picture

DevElCuy CreditAttribution: DevElCuy commented

There you go @malberts!

DevElCuy’s picture

DevElCuy CreditAttribution: DevElCuy commented
Status: Needs work » Fixed

  • develCuy committed 98aaab1 on 7.x-1.x authored by malberts 
    Issue #1895628 by malberts: Entity type does not necessarily match token...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.