Similar to other issues we should do that.

CommentFileSizeAuthor
#13 vdc-1891198-13.patch443 bytestim.plunkett
#9 vdc-1891198-9.patch40.49 KBdawehner
#6 move_views_test-1891198-5.patch39.66 KBdawehner
#5 move_views_test-1891198-5.patch164.83 KBdawehner
#4 drupal-1891198-4.patch34.75 KBdawehner
#1 drupal-1891198-1.patch34.34 KBdawehner

Comments

dawehner’s picture

dawehner
Primary language German
commented
Status: Active » Needs review
StatusFileSize
new drupal-1891198-1.patch34.34 KB

There we go.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Issue tags: -VDC

#1: drupal-1891198-1.patch queued for re-testing.

Status: Needs review » Needs work
Issue tags: +VDC

The last submitted patch, drupal-1891198-1.patch, failed testing.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs work » Needs review
StatusFileSize
new drupal-1891198-4.patch34.75 KB

Rerole

dawehner’s picture

dawehner
Primary language German
commented
StatusFileSize
new move_views_test-1891198-5.patch164.83 KB

Another rerole.

dawehner’s picture

dawehner
Primary language German
commented
StatusFileSize
new move_views_test-1891198-5.patch39.66 KB

What a fail.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Needs review » Reviewed & tested by the community

RTBC if green.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Needs work

Some new stuff has been added afaics...

ll core/modules/views/tests/views_test_config/test_views/
total 16
drwxr-xr-x  2 alex  staff  136  9 Jun 15:25 .
drwxr-xr-x  3 alex  staff  102  9 Jun 15:25 ..
-rw-r--r--  1 alex  staff  636  4 Jun 19:18 views.view.test_display_invalid.yml
-rw-r--r--  1 alex  staff  554  9 Jun 13:28 views.view.test_entity_row.yml
dawehner’s picture

dawehner
Primary language German
commented
Status: Needs work » Needs review
StatusFileSize
new vdc-1891198-9.patch40.49 KB

A hopefully final rerole.

dawehner’s picture

dawehner
Primary language German
commented
Issue tags: +PHPUnit

Add another tag

ParisLiakos’s picture

ParisLiakos commented
Status: Needs review » Reviewed & tested by the community

yes this will allow using test classes in phpunit:)
applied patch locally and moves all files!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed ca484d9 and pushed to 8.x. Thanks!

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Title: Move views test helper modules to views/tests/modules. » [HEAD BROKEN] Move views test helper modules to views/tests/modules.
Status: Fixed » Reviewed & tested by the community
StatusFileSize
new vdc-1891198-13.patch443 bytes

#2011006: Default local tasks provided by Views are broken added a test view that didn't get moved.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Category: task » bug
Priority: Normal » Critical
webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Title: [HEAD BROKEN] Move views test helper modules to views/tests/modules. » Move views test helper modules to views/tests/modules.
Category: bug » task
Priority: Critical » Normal
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.