Strict warning: Declaration of TMGMTPluginsTestCase::createJob() should be compatible with TMGMTBaseTestCase::createJob($source = 'en', $target = 'de', $uid = 1) in _registry_check_code() (line 3115 of /home/qa/Bones/Drupal-HD/pressflow/includes/bootstrap.inc).

CommentFileSizeAuthor
#9 tmgmt-strict-errors-1889606-2.patch2.7 KBethanethan
#6 tmgmt-strict-errors-1889606.patch2.58 KBethanethan

Comments

ethanethan’s picture

ethanethan commented

Actually there are more, all dealing with the setUp() method. Am i doing something wrong?

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

This is because are using PHP 5.4. Noticed it too but it's not a really a problem, so no need to worry.

ethanethan’s picture

ethanethan commented

But you wouldn't say no to a patch :) ? When we update our modules, we overwrite, so it would be helpful if the TMGMT repo had this fix.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

Sure, patches are welcome.

ethanethan’s picture

ethanethan commented
Assigned: Unassigned » ethanethan
ethanethan’s picture

ethanethan commented
StatusFileSize
new tmgmt-strict-errors-1889606.patch2.58 KB

A little refactoring needed for this one.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, tmgmt-strict-errors-1889606.patch, failed testing.

ethanethan’s picture

ethanethan commented
Status: Needs work » Needs review
StatusFileSize
new tmgmt-strict-errors-1889606-2.patch2.7 KB

Needed to use the same strategy in TMGMTBaseTestCase setUp() as DrupalWebTestCase setUp() to get modules param.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Fixed

Looks good, thanks!

Commited and pushed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.