Closed (fixed)
Project:
Textimage
Version:
7.x-2.x-dev
Component:
Code
Priority:
Critical
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
15 Jan 2013 at 10:31 UTC
Updated:
10 Feb 2013 at 19:50 UTC
Jump to comment: Most recent file
Comments
Comment #1
dmitriy.trt commentedPatch fixes the fatal error only. There is one more call to the
getDirectoryPath()of the stream wrapper without it's check, so issue needs more work after fixing the critical part. Unfortunately at the moment I can't work on it, because we're using Textimage module directly through the API only.Comment #2
mondrakeHi, and thanks for the patch.
Does this mean that
a) in your environment you are overriding the local stream wrapper for 'public' with some other wrapper, and
b) you are only generating Textimage images through theme('textimage_image', ...) passing a file_path key through the variables?
Comment #3
dmitriy.trt commentedHi,
a) "public://" is just a default scheme to store files on local filesystem. We're using Azure module to create custom "azure-storage://" scheme with non-local stream wrapper. This scheme is selected as "Default download method" on the
admin/config/media/file-systempage.b) We use it in a bit different way, by direct calls to
textimage_get_presets()&textimage_image_from_preset(), because preset has to be adjusted for each and every image and result image is copied to the other GD image in our case.Comment #4
mondrakeAlrigth, thanks for feedback.
It makes sense to me; I will wait 2 weeks to see if any community review comes, and then commit it to dev.
I do not think the other instance of
getDirectoryPath()poses a problem, since if the menu path does not get created, as per your patch,textimage_deliver()will never get invoked.Comment #5
mondrakeCommitted and pushed to dev. Thank you!