Closed (fixed)
Project:
Slideshow Creator
Version:
7.x-1.11
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
12 Jan 2013 at 13:40 UTC
Updated:
12 Mar 2013 at 09:40 UTC
This is a small patch that allows people to add a class to the external slideshow span when embedding a slideshow.
The 'name' attribute already adds such a class, and sometimes you want a class that can be used across multiple slideshows (eg classes for floating the slideshow left and right)
I was unable to get leatest HEAD working on my site; this patch is against 7.x-1.11
| Comment | File | Size | Author |
|---|---|---|---|
| slideshow-creator-add-class.patch | 1.01 KB | nirbhasa |
Comments
Comment #1
rhouse commentedHi thanks for that. I am not sure what you see as the purpose of this patch. As you say, the name attribute already allows adding a class, so why do we need another tag for the same purpose? Can you give me a specific example so I can understand the necessity?
Re HEAD, you should be connecting to the specific version branch, 6.x-1.x or 7.x-1.x. HEAD is no longer used in this project and consists of old junk from the CVS dark ages.
Comment #2
nirbhasa commentedMy specific use case is I have a large community site with many editors who have the ability to add slideshows, and I want my editors to have the choice of floating their slideshow to the left or to the right of the text.
So I have a "left" and "right" class in my theme, and I can then tell my editors to add class=left or class=right to the embed code to achieve the desired result.
So as regards a general use case - I guess it is where a site developer wants to create a set of fixed theming options that editors can optionally use with their slideshow.
Comment #3
rhouse commented#2, I understand what you are trying to do, but I don't understand why your users can't just write name=left or name=right ? Why do we specifically need to add a second method of doing the same thing?
The only difference I can see with your proposal is that it adds the specified class to any default class set in the general settings, whereas specifying name again will replace them. Is that the problem?
Comment #4
rhouse commentedUpon thinking more about it, I feel that "name" is a very bad name for a tag that sets the css class, so I am deprecating the name "name" and introducing a new tag called "class" that is the same as "name" but better named.
Also I have just found that the 'name' tag doesn't work if listed in the Default Tags settings, so I am taking the opportunity to make the new 'class' tag work properly there and with some new functionality.
Although I haven't used your code, I have given you credit in the commit for giving me the idea.
Comment #5
nirbhasa commentedHi - Thanks for that. To answer your comment in #3, i was under the wrong impression that name was a unique per-slideshow attribute. But your solution in #4 takes care of everything :)