Seems results of that call doesn't used, and parameters didn't modified be reference.

#1 remove-useless-node_type_get_type-call-1886870.patch657 bytesIRuslan
PASSED: [[SimpleTest]]: [MySQL] 39,694 pass(es). View
Members fund testing for the Drupal project. Drupal Association Learn more


IRuslan’s picture

657 bytes
PASSED: [[SimpleTest]]: [MySQL] 39,694 pass(es). View

Patch is added.

arknoll’s picture

Status: Needs review » Reviewed & tested by the community

Patch does remove an unneeded call to node_type_get_type.

David_Rothstein’s picture

Status: Reviewed & tested by the community » Fixed

Looks good, and looks like the equivalent code in Drupal 8 does not have this issue.

Committed to 7.x - thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

Issue summary: View changes

Fix typo.