This is a follow up issue of #1879148: Replace variable editor for D8. In #10 @moshe suggested that the rendering process of the variable page could be improved.

CommentFileSizeAuthor
#1 render_variable-1886836-1.patch1.52 KBplopesc

Comments

plopesc’s picture

plopesc
he/him
Primary language Spanish
commented
Status: Active » Needs review
StatusFileSize
new render_variable-1886836-1.patch1.52 KB

Hello

Attaching patch that changes the rendering process of the variable page. As other form based pages, drupal_get_form() is defined as page callback in hook_menu().

If you consider any other preferred option, tell me please. Any suggestion is welcomed.

Regards.

Status: Needs review » Needs work

The last submitted patch, render_variable-1886836-1.patch, failed testing.

moshe weitzman’s picture

moshe weitzman commented
Status: Needs work » Fixed
moshe weitzman’s picture

moshe weitzman commented

Committed to D7 and D8.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.