If this code resembles the bundle filter, that's no wonder ;)

CommentFileSizeAuthor
#4 1886738-4--user_role_filter.patch3.23 KBdrunken monkey
#3 1886738-3.patch2.85 KBjelle_s
#2 1886738-2.patch2.86 KBjelle_s
SearchApiAlterRoleFilter.patch2.78 KBchx

Comments

chx’s picture

chx commented
Status: Active » Needs review
jelle_s’s picture

jelle_s
Primary language Dutch
Location Antwerp, Belgium
commented
StatusFileSize
new 1886738-2.patch2.86 KB

New patch.

  • Fixed typo $default = (bool) $this->options['roles']; => $default = (bool) $this->options['default'];
  • Users are in- or excluded if they have one (instead of all) of the selected roles.
jelle_s’s picture

jelle_s
Primary language Dutch
Location Antwerp, Belgium
commented
StatusFileSize
new 1886738-3.patch2.85 KB

Sorry, ignore previous patch. It filters out the opposite of what the user selected. This is the right patch.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
StatusFileSize
new 1886738-4--user_role_filter.patch3.23 KB

Seems to work perfectly, thanks for suggesting this and providing a patch!
Attached is a re-roll to use the new $index->getEntityType() function and fixing the documentation style a bit.
Please test/review!

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Status: Needs review » Fixed

Committed. Thanks again!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.