There is no hook_link() in D7; it was removed.

Therefore documentation that says 'the same format as hook_link()' is not very helpful now.

The mentions of 'hook_link' in the docs hook_flag_link() for should be updated, and the actual format explained in full detail.

AFAICT this only returns an array with title and href, at least in our implementation of it. Would be good to check what the module code does with what it gets from the invocation of that hook, just to be sure what its effective spec is!

CommentFileSizeAuthor
#5 replace_mention_of_hook_link_with_proper_description-1886512_5.patch1.23 KBemartoni
#2 replace_mention_of_hook_link_with_proper_description-1886512.patch863 bytespbose_drupal

Comments

laughnan’s picture

laughnan
he/him/his
commented
Assigned: Unassigned » laughnan
Issue summary: View changes

It seems like this isn't every called for any files in 7.x-3.x. I could write a patch to update the API documentation if you'd like.

pbose_drupal’s picture

pbose_drupal commented
StatusFileSize
new replace_mention_of_hook_link_with_proper_description-1886512.patch863 bytes

I just went through the module and updated the description. See the patch attached.

rajeevk’s picture

rajeevk
Location London
commented
Assigned: laughnan » Unassigned
Status: Active » Needs review

Changing status to NR to test patch.

emartoni’s picture

emartoni commented
Status: Needs review » Needs work

Hi @pbose_drupal, how are you?

Patch works, but I found some problems:
* Typo:
Query Parameters which includes desitnation , token etc.

* Line break issue:

 * Note that "title" is
 * provided by the Flag configuration if not specified here.
emartoni’s picture

emartoni commented
Status: Needs work » Needs review
StatusFileSize
new replace_mention_of_hook_link_with_proper_description-1886512_5.patch1.23 KB

Patch attached!

Best,
Eduardo

ivnish’s picture

ivnish
he/him
commented
Status: Needs review » Closed (outdated)
Issue tags: -Novice

Drupal 7 is EOL. Issue will be closed, but patches are still here