There should be a copy of the expected schema for each sanitization in http://drupalcode.org/project/infrastructure.git/tree/HEAD:/snapshot. The schema can be exported with mysqldump -d and any other options needed to remove timestamps or simplify the data. Early in the process, snapshot.sh should check if the DB it has matches that schema. If it does not match, it should fail the job, not making any more snapshots until we have reviewed the changes.

Comments

drumm’s picture

drumm
he/him
Location NY, US
commented
Assigned: Unassigned » drumm

I did the first step of this, figuring out what schemas we have now. The output of mysqldump … -d --compact --skip-opt is now saved to schema.mysql early in the snapshot process.

eliza411’s picture

eliza411 commented

@drumm - I think this issue can be closed now. With the whitelist approach, the exports will run but will NOT include the schema changes. Instead, a snippet is produced for how to add the schema change to the whitelist, at which time, sanitization can be performed.

I think this satisfies the intent here and goes a little beyond by making it easier to update.

If there's more that needs to be done, let me know.

drumm’s picture

drumm
he/him
Location NY, US
commented
Issue summary: View changes
Status: Active » Closed (duplicate)

Agreed.

Component: Database » Servers

  • drumm committed 991601f on isntall-00 
    [#1884780] Save a copy of the schema we are sanitizing.