Could we allow destination to be set for view/edit/add links on the overview page?

CommentFileSizeAuthor
#4 et-overview_destination_links-1883584-4.patch1.66 KBplach
#1 1883584-1-et_allow_destination_on_overview_links.patch1.61 KBgrndlvl
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

grndlvl’s picture

grndlvl CreditAttribution: grndlvl commented
Status: Active » Needs review
FileSize
1883584-1-et_allow_destination_on_overview_links.patch1.61 KB
plach’s picture

plach
he/him
Primary language Italian
Location Venezia
CreditAttribution: plach commented

Looks sensible to me, I will need to this.

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
CreditAttribution: plach commented

I tested this and it seems good. I don't agree with the following, though:

         $link = isset($links->links[$langcode]['href']) ? $links->links[$langcode] : array('href' => $path, 'language' => $language);
+        $link['query'] = drupal_get_destination();
         $row_title = l($label, $link['href'], $link);

I think that if one navigates away from the translation overview instead of taking an action the destination should be discarded. I can fix this on commit if you agree.

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
CreditAttribution: plach commented
Status: Needs review » Fixed
FileSize
et-overview_destination_links-1883584-4.patch1.66 KB

Committed and pushed the attached patch, thanks.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit 754fde8 on 7.x-1.x, factory, et-fc, revisions authored by grndlvl, committed by plach: 
    Issue #1883584 by grndlvl: Added Allow for link 'destination' on...
  • Commit 606f5da on 7.x-1.x, factory, et-fc, revisions by plach:
    Issue #1883584 by grndlvl: Do not set destination when it is not defined...

  • Commit 754fde8 on 7.x-1.x, factory, et-fc, revisions, workbench authored by grndlvl, committed by plach: 
    Issue #1883584 by grndlvl: Added Allow for link 'destination' on...
  • Commit 606f5da on 7.x-1.x, factory, et-fc, revisions, workbench by plach:
    Issue #1883584 by grndlvl: Do not set destination when it is not defined...