Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
As far as the PHPUnit stuff, please ignore. D8's autoloader can't find the test class in a nested directory like the one for Examples. It will have to wait. I'm unable to find an issue on it.
Also, never set the status to 'closed (fixed).' Just 'fixed' is good. :-)
Comments
Comment #1
marvil07 CreditAttribution: marvil07 commentedHere the port!
Comment #2
marvil07 CreditAttribution: marvil07 commentedAdded to 8.x-1.x!
Comment #4
marvil07 CreditAttribution: marvil07 commentedAdded a follow up to use new routing system.
Comment #5
Mile23That looks great.
But I'd really like to see phpunit tests. For instance, the tests never see the AccessDeniedHttpException, even though it's declared as a dependency. Viz: http://phpunit.de/manual/3.2/en/writing-tests-for-phpunit.html#writing-t...
I don't mean convert everything to phpunit. I *do* mean: Add phpunit tests that cover dependencies. I'll have to write up a policy issue about this.
Comment #6
marvil07 CreditAttribution: marvil07 commentedOk, can please you please elaborate on the issue I have just opened: #2022601: Use phpunit on page example
IMHO current code here is good enough to start, so let's do the rest on individual issues.
Comment #7
Mile23As far as the PHPUnit stuff, please ignore. D8's autoloader can't find the test class in a nested directory like the one for Examples. It will have to wait. I'm unable to find an issue on it.
Also, never set the status to 'closed (fixed).' Just 'fixed' is good. :-)