Add a Views sort handler which allows combining the nodequeue position with another (random) parameter [#1881956]

Hello. I have problem with sort nodes by nodequeue position and date.
I want to display 20 nodes. Display 5 first nodes ordered by nodequeue position and 15 next nodes ordered by date.

I wrote a handler that solves this problem. I am sure that it will be useful to many people.

Just for example look at screenshots:

By default http://i.imgur.com/7hHv8.png
With my handler http://i.imgur.com/wrCOI.png

Comment	File	Size	Author
#6	nodequeue-handler-sort-nodes-by-position-before-null-1881956-5.patch	2.51 KB	eugene.ilyin
#5	nodequeue-handler-sort-nodes-by-position-before-null-1881956-5.patch	0 bytes	eugene.ilyin
#1	nodequeue-handler-sort-nodes-by-position-before-null-1881956.patch	2.27 KB	eugene.ilyin
	wrCOI.png	40.23 KB	eugene.ilyin

Comments

Status	File	Size
new	nodequeue-handler-sort-nodes-by-position-before-null-1881956.patch	2.27 KB

Comment #2

eugene.ilyin commented 7 January 2013 at 10:19

Status:

Active

» Needs review

Comment #3

eugene.ilyin commented 7 January 2013 at 10:23

If this patch is usefull for you, please add me as author of commit of this patch. It's very important for me, thanks!

Comment #4

amateescu commented 15 January 2013 at 12:24

Status:

Needs review

» Needs work

This seems like a nice use-case and solution, but it took me a while to figure out what was the problem that you were trying to solve :) This is only useful if you don't restrict the view to nodes that are in a queue, right?

Could you improve the text (help, title) in the patch to reflect this? And maybe find a better title than 'Sort nodes by position before null', because no one will actually figure out what it does only by that name.

Also, about the patch:
1) you are assuming that a nodequeue is limited to 99999 nodes, which I don't think it's the case, so it wouldn't hurt to increase that number a bit.
2)

+++ b/includes/views/nodequeue_handler_sort_by_position_before_null.inc
@@ -0,0 +1,27 @@
'direction' => strtoupper($this->options['order'])

You have already done this operation above and you have the result in the $order variable.

Comment #5

eugene.ilyin commented 16 January 2013 at 17:43

Status:

Needs work

» Needs review

Status	File	Size
new	nodequeue-handler-sort-nodes-by-position-before-null-1881956-5.patch	0 bytes

Comment #6

eugene.ilyin commented 16 January 2013 at 17:43

Status	File	Size
new	nodequeue-handler-sort-nodes-by-position-before-null-1881956-5.patch	2.51 KB

Hello

I updated the patch. I tried to add a good title and description for the handler, but my English is not very good. If something is wrong, please correct me.

I would appreciate if you add me as the author of commit. Thanks.

Comment #7

16 January 2013 at 18:15

Status:

Needs review

» Needs work

The last submitted patch, nodequeue-handler-sort-nodes-by-position-before-null-1881956-5.patch, failed testing.

Comment #8

eugene.ilyin commented 16 January 2013 at 18:18

Status:

Needs work

» Needs review

#6: nodequeue-handler-sort-nodes-by-position-before-null-1881956-5.patch queued for re-testing.

Comment #9

amateescu commented 18 January 2013 at 12:56

Title:	Sort nodes by nodequeue position before null	» Add a Views sort handler which allows combining the nodequeue position with another (random) parameter
Version:	7.x-2.x-dev	» 7.x-3.x-dev
Status:	Needs review	» Fixed