Closed (fixed)
Project:
Graph API
Version:
7.x-1.x-dev
Component:
Code
Priority:
Major
Category:
Bug report
Assigned:
Issue tags:
Reporter:
Created:
6 Jan 2013 at 09:30 UTC
Updated:
4 Jan 2014 at 02:42 UTC
Jump to comment: Most recent
The way views need it's defaults should not be provided by implementing modules.
This is a release blocker.
Comments
Comment #1
clemens.tolboomThe default settings for a module should be just that and not a preparation of views quirks.
Comment #2
clemens.tolboomI ran into this again through option_definition() not having nested default values.
[edit: not the cause]
Changing<?php
// Add settings provided by plugin engines.
- $options += module_invoke_all('graphapi_default_settings');
+ $engines = graphapi_views_formats();
+ foreach ($engines as $engine => $dummy) {
+ $from_engine = module_invoke( $engine, 'graphapi_default_settings');
+ $options[$engine] = $from_engine[$engine];
+ }
let the values be saved for ie graph_phyz physics settings.XREF : Core: #222074: PHP bug/feature in array_merge_recursive() causes warning messages
Comment #3
clemens.tolboomThere was a bug regarding boolean values. That's now fixed.
But it's not possible to remove the hook as modules know what their values are including translation. So we keep it this way.