Will update this issue summary as I get issues filed.

  1. Backport D8 Edit module to D7: #1879824: Backport D8 Edit module to D7
  2. Drop dependency on FAPE: #1879826: Drop dependency on FAPE
  3. BC with jQuery 1.4.4: #1880474: Make code compatible with jQuery 1.4.4
  4. Edit integration with CKEditor: #1879832: Edit module integration with CKEditor
  5. Toolbar integration: #1879828: Per-entity "Quick edit" link — i.e.: the same interaction as the D8 version
  6. General clean-up of critical/major bugs
  7. #1798458: Add support for node titles powered by Panels panes and #1740970: Panels' CSS interferes with in-place editing of display:inline fields
  8. #1815244: You cannot edit fields if they are floating under other fields
  9. Views Integration: #1830518: Views integration (use Views' render pipeline to re-render edited fields in Views) and #1900462: Support Rendered Entity Views field
  10. Provide a JS API: #1900454: Provide a JS API to call the edit form for a given field
  11. Be sure we're showing sane values for the fields while editing them:#1900436: Critical regression: Untransformed text no longer retrieved (causing the user to edit the filtered text instead o/t source text)

#1678002: Edit should provide a usable entity-level toolbar for saving fields is the biggest outstanding question mark, in terms of a stable 1.0 release, so I'd rather de-scope that from this for now since it needs to be fixed in D8 first. However, it should be possible to make the Edit module code in D8 HEAD right now usable on D7 without blowing anything up. :D

Comments

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Issue tags: +Edit D7 Backport

Making up a tag for this initiative.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Issue summary: View changes

x

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Issue summary: View changes

x

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Title: Get the D7 version of Edit production-ready » [meta] Get the D7 version of Edit production-ready

Annnd making a meta issue.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Assigned: nod » nod_

Hehe, wrong nod_. :D

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Issue summary: View changes

x

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Issue summary: View changes

x

nod_’s picture

nod_
Primary language French
Location Lille
commented

reordering tasks in the order i'll work on it most likely.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented

We had a kick-off call earlier today with nod_, Wim Leers, and myself, mostly talking through some of the critical/major issues. I've left comments here about the conclusions we reached on the call, if people have input:

- #1879828: Per-entity "Quick edit" link — i.e.: the same interaction as the D8 version
- #1880474: Make code compatible with jQuery 1.4.4
- #1879832: Edit module integration with CKEditor

D8 backport is making good progress already, so that's great news. :)

Also got some information on Théodore's availability, which is:

Jan 7 - Jan 11: All Spark, all the time
Jan 14 - Jan 18: AFK for client work
Jan 21 - Feb 1: All Spark, all the time

I'm planning to use that week in between to incorporate Théodore's work into Spark and test the beejeezus out of it. :)

nod_’s picture

nod_
Primary language French
Location Lille
commented
Issue summary: View changes

reorder tasks

nod_’s picture

nod_
Primary language French
Location Lille
commented

Quick update: 1) 2) and 3) have been solved pretty much. They need testing and code needs cleaning up but it works.

no more dependency on FAPE or jquery_update :)

It's in this branch http://drupalcode.org/project/edit.git/shortlog/refs/heads/node/1808076-... and a core patch is needed #1821906-26: Allow more Field API public API functions to act on a single field within an entity.

7wonders’s picture

7wonders commented

I just tried the branch in #6 and its working great together with the "quick edit" block in that its very fluid, fast and intuitive. You have to excuse me as its the first time I am trying edit, but the only thing that I found was that it allowed me to try and edit fields that I do not have permission to edit (the blue select boxes around all fields). Clicking X to close worked fine but if clicking save throws the ajax 500 error. Is there somewhere that I can find more info on how to show edit only for specific fields? Great job so far!

nod_’s picture

nod_
Primary language French
Location Lille
commented

There will be a review/testing by webchick next week to list all the problems we created/solved during the backport and in 2 weeks I'm back to fix all the things :) Today I'll be merging all the work into the 7.x-1.x branch and do some refactoring of a few things.

But that's good to know, i'll see if I run into it today.

nod_’s picture

nod_
Primary language French
Location Lille
commented

Changes merged into 7.x-1.x.

nod_’s picture

nod_
Primary language French
Location Lille
commented
Issue summary: View changes

actual order

nod_’s picture

nod_
Primary language French
Location Lille
commented

4) just landed. Should be working okay, some details in #1879832-9: Edit module integration with CKEditor
I postponed 5) until we get a better Idea

Leaves me with something like 8 days for clean-up and helping the scald team with their integration in edit.

Also, updated schedule:
Jan 15 — Jan 28: All Spark, all the time (this still need final confirmation but it's very likely).

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented

Just as another update, I've fixed up the 7.x-1.x version of the Spark distro with the latest code to help people with testing.

The easiest thing to do is clone it from git and build it manually with drush make:

cd ~/Sites # or wherever www root is
git clone --recursive --branch 7.x-1.x http://git.drupal.org/project/spark.git
cd spark
drush make build-spark.make spark

Then go to http://localhost/spark/spark to test.

If you're a patient person, you can also wait for 7.x-1.x to package and download and test that every ~12 hours.

Please feel free to report bugs, but make sure to check this list first: http://drupal.org/project/issues/search/edit?issue_tags=Edit+D7+Backport

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Issue summary: View changes

adds couple issues

nod_’s picture

nod_
Primary language French
Location Lille
commented

Looking at #1895526: Add a way to make things that don't use Field API in-place editable

wundo’s picture

wundo commented

I've spent today testing the module - sorry for all the issues :) - and I think the following issues are critical for a stable D7 release:

wundo’s picture

wundo commented
Issue summary: View changes

.

wundo’s picture

wundo commented
Issue summary: View changes

Updating ticket description

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented

Ok, just rolled a new release of Edit module as well as Spark so people can try this out.

We're not quite there yet in terms of "production-ready", but Radio France's sponsorship of the work for the past 3 weeks definitely got us much further along! http://buytaert.net/radio-france-sponsors-spark-drupal-7-work Thank you so much!

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Active » Closed (fixed)

I'm going to go ahead and mark this issue fixed, since the battleplan here has long since been completed.

The final production-ready stuff will happen in #2111667: Backport Drupal 8's Edit module to Drupal 7 and related sub-issues.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Issue summary: View changes

Sorry, Sunday night typo