'Address Book' tab on user account page is quite high in weight [#1877444]

Hey.

Just got to styling up my user account page on a new site I'm building and noticed that the 'Address book' tab seems to be quite high in the tabs list, its even before edit.

I'm guess its quite easy to change with hook_menu_alter(), But IMHO I get the feeling that by default it should be at least after 'Edit'.

What do people think?

Comment	File	Size	Author
#1	1877444-1.patch	484 bytes	m.stenta
#1	1877444-1-screenshot.png	10.95 KB	m.stenta

Comments

Comment #1

m.stenta

he/him

English

commented 27 January 2013 at 00:10

Version:	7.x-2.0-rc3	» 7.x-2.x-dev
Status:	Active	» Needs review

Status	File	Size
new	1877444-1-screenshot.png	10.95 KB
new	1877444-1.patch	484 bytes

Agreed. "View" and "Edit" should be adjacent, for consistency.

The "View" tab has a weight of -10 in user.module, and the "Edit" tab has a default weight of 0.

Out-of-the box, Commerce also adds the "Orders" tab if you have the Commerce Orders UI module enabled. This is provided by Views, and has a default weight of 15. In my opinion, the Address Book tab should come after "Orders".

So I'm proposing a weight of 20. Patch attached (against the current 7.x-2.x branch).

Also attached is a quick screenshot I took of the new arrangement. I think it looks nice... small to big. :-)

Comment #2

ressa

he/him

commented 27 January 2013 at 15:35

Talk about timing, I just got the same thought -- to bump the "Address Book" link down at the end.
And you're right, on top of belonging there, it does look nicer visually. I visited your web site and noticed the trend in your own menu links :-) I really liked "Portraits of Movement".