Follow-up from #1416372: Translator Plugin: Local User.

Decide if we really want default auto approve to 1, not sure if that makes sense. Maybe the server should do that in the server installation profile instead.

CommentFileSizeAuthor
#13 remove-default-accept-1876986-13.patch2.91 KBberdir
#10 remove-default-accept-1876986-10.patch2.43 KBcgalli
#7 remove-default-accept-1876986-7.patch639 bytescgalli
#1 remove-default-accept-1876986-1.patch616 bytesberdir

Comments

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Active » Needs review
StatusFileSize
new remove-default-accept-1876986-1.patch616 bytes

This will make the tests fail.

Any objections to doing this?

cgalli’s picture

cgalli commented

Yes, possibly.

Using the LUI with auto accept OFF on the same installation as the jobs are created it leads to confusing status and color displays.
See issue 1416372, #40

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

It was already partially improved by using the same configuration for the colors.

And that's not an argument against this, we need to improve that anyway even if it's not the default setting.

Status: Needs review » Needs work

The last submitted patch, remove-default-accept-1876986-1.patch, failed testing.

Anonymous’s picture

(not verified) commented
Issue summary: View changes

Updated issue summary.

cgalli’s picture

cgalli commented
Status: Needs work » Needs review

1: remove-default-accept-1876986-1.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, 1: remove-default-accept-1876986-1.patch, failed testing.

cgalli’s picture

cgalli commented
Issue summary: View changes
StatusFileSize
new remove-default-accept-1876986-7.patch639 bytes

Redo the patch with current code base
Let's see if and where test fails

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 7: remove-default-accept-1876986-7.patch, failed testing.

cgalli’s picture

cgalli commented
Component: Core » Translator: Local
Status: Needs work » Needs review
StatusFileSize
new remove-default-accept-1876986-10.patch2.43 KB

Adapted tests to accept translations, should pass now

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

$job->acceptTranslation() should also work and has much less overhead.

cgalli’s picture

cgalli commented

I tried before. Did not work:

    $items = $job->getItems();
    $items[1]->acceptTranslation();
    $this->drupalGet('translate/1');

The reloaded page does not show the new status of the the job item.

Is there another way to reaload the page?

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
StatusFileSize
new remove-default-accept-1876986-13.patch2.91 KB

Welcome to the wonderful world of static cache and web tests. Always a wonderful experience :)

blueminds’s picture

blueminds commented
Status: Needs review » Reviewed & tested by the community

looks good

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Reviewed & tested by the community » Fixed

Thanks, committed and pushed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.