There are lots of lines in the module that use $type and $id whereas they should use $entity_type and $entity_id.

Files: 
CommentFileSizeAuthor
#4 metatag-n1876042-4.patch1.57 KBDamienMcKenna
PASSED: [[SimpleTest]]: [MySQL] 73 pass(es). View
#1 metatag-n1876042-1.patch15.48 KBDamienMcKenna
PASSED: [[SimpleTest]]: [MySQL] 21 pass(es). View

Comments

DamienMcKenna’s picture

Status: Active » Needs review
FileSize
15.48 KB
PASSED: [[SimpleTest]]: [MySQL] 21 pass(es). View

This covers both variables.

DamienMcKenna’s picture

Status: Needs review » Fixed

Committed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

DamienMcKenna’s picture

Issue summary: View changes
Status: Closed (fixed) » Needs review
FileSize
1.57 KB
PASSED: [[SimpleTest]]: [MySQL] 73 pass(es). View

A follow-up to fix some occurrences of $id in metatag.admin.inc.

DamienMcKenna’s picture

Status: Needs review » Fixed

Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.