Closed (fixed)
Project:
Drupal core
Version:
7.x-dev
Component:
documentation
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Anonymous (not verified)
Created:
28 Dec 2012 at 21:19 UTC
Updated:
9 Mar 2022 at 12:26 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
jhodgdonGood catch!
While we're fixing this, first line should be changed from "Inform modules that..." to say "Respond to...".
http://drupal.org/node/1354#hooks
Comment #2
ParisLiakos commentedThis got fixed for d8 in #1814916: Convert menus into entities
Comment #3
cck commentedD7 patch for #1.
Comment #4
j.slemmer commentedComment #5
jhodgdonThere is still a problem in D8 that needs to be addressed (which is addressed in this d7 patch, but we need to fix d8 before fixing d7): the first lines of all the hook docs in menu.api.php are incorrect. So can we get a patch for d8 that fixes them as in the existing d7 patch? Thanks!
Oh actually, the d7 patch says things like:
Respond to a custom menu was created.
That isn't very good English. How about "Respond to custom menu creation"? And similar for the other hooks.
Comment #6
ParisLiakos commentedoops,seems i missed #1..sorry for the noise.restoring tag as well
Comment #7
cck commentedOk. I will follow up on this.
Comment #8
cck commentedThis D8 patch corrects the subject line.
Comment #9
jhodgdonThanks! Please change "Responds" to "Respond" -- see
http://drupal.org/node/1354#hooks
Comment #10
cck commentedHi, the correction is included in this version.
Comment #11
jhodgdonLooks good! I'll get this committed to 8.x shortly, and then we can return to the 7.x patch.
Comment #12
jhodgdonThanks again -- Committed the patch in #10 to Drupal 8.
Now we can return to the patch in #3 for Drupal 7, which needs the first lines of the hook documentation to look like the patch in #10.
Comment #13
j.slemmer commentedHow about this? See patch...
Comment #14
cck commentedHi, -13 patch needs another fix in hook_menu_delete. You can look at -1.patch. This @link parameter is fixed in D8. This is why it is not included in the D8 patch.
Comment #15
j.slemmer commentedAdded that change. How about now?
Comment #16
j.slemmer commentedComment #17
jhodgdonLooks good -- thanks! I'll get this committed shortly.
Comment #18
jhodgdonThanks again -- this is committed to 7.x.