Comments

jhodgdon’s picture

Version: 7.x-dev » 8.x-dev
Issue tags: +Novice, +Needs backport to D7

Good catch!

While we're fixing this, first line should be changed from "Inform modules that..." to say "Respond to...".
http://drupal.org/node/1354#hooks

ParisLiakos’s picture

Version: 8.x-dev » 7.x-dev
Issue tags: -Needs backport to D7

This got fixed for d8 in #1814916: Convert menus into entities

cck’s picture

Assigned: Unassigned » cck
StatusFileSize
new1.33 KB

D7 patch for #1.

j.slemmer’s picture

Status: Active » Needs review
jhodgdon’s picture

Version: 7.x-dev » 8.x-dev
Status: Needs review » Needs work

There is still a problem in D8 that needs to be addressed (which is addressed in this d7 patch, but we need to fix d8 before fixing d7): the first lines of all the hook docs in menu.api.php are incorrect. So can we get a patch for d8 that fixes them as in the existing d7 patch? Thanks!

Oh actually, the d7 patch says things like:

Respond to a custom menu was created.

That isn't very good English. How about "Respond to custom menu creation"? And similar for the other hooks.

ParisLiakos’s picture

Issue tags: +Needs backport to D7

oops,seems i missed #1..sorry for the noise.restoring tag as well

cck’s picture

Ok. I will follow up on this.

cck’s picture

Status: Needs work » Needs review
StatusFileSize
new1.07 KB

This D8 patch corrects the subject line.

jhodgdon’s picture

Status: Needs review » Needs work

Thanks! Please change "Responds" to "Respond" -- see
http://drupal.org/node/1354#hooks

cck’s picture

Status: Needs work » Needs review
StatusFileSize
new1.07 KB

Hi, the correction is included in this version.

jhodgdon’s picture

Assigned: cck » jhodgdon
Status: Needs review » Reviewed & tested by the community

Looks good! I'll get this committed to 8.x shortly, and then we can return to the 7.x patch.

jhodgdon’s picture

Version: 8.x-dev » 7.x-dev
Status: Reviewed & tested by the community » Needs work

Thanks again -- Committed the patch in #10 to Drupal 8.

Now we can return to the patch in #3 for Drupal 7, which needs the first lines of the hook documentation to look like the patch in #10.

j.slemmer’s picture

Status: Needs work » Needs review
StatusFileSize
new1.05 KB

How about this? See patch...

cck’s picture

Status: Needs review » Needs work

Hi, -13 patch needs another fix in hook_menu_delete. You can look at -1.patch. This @link parameter is fixed in D8. This is why it is not included in the D8 patch.

j.slemmer’s picture

Added that change. How about now?

j.slemmer’s picture

Status: Needs work » Needs review
jhodgdon’s picture

Status: Needs review » Reviewed & tested by the community

Looks good -- thanks! I'll get this committed shortly.

jhodgdon’s picture

Assigned: jhodgdon » Unassigned
Status: Reviewed & tested by the community » Fixed

Thanks again -- this is committed to 7.x.

Automatically closed -- issue fixed for 2 weeks with no activity.