#1196828: add microdata support for image (core) added the theme_microdata_image_formatter() because theme_image_formatter() did not account for custom attributes.

However as from Drupal 7.14 this has been fixed as per #1329586: theme_image_formatter should pass along attributes.

CommentFileSizeAuthor
#1 1875346-1-remove_theme_microdata_image_formatter.patch1.95 KBfenstrat
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

fenstrat’s picture

fenstrat
he/him
Primary language English
Location Australia
CreditAttribution: fenstrat commented
Status: Active » Needs review
FileSize
1875346-1-remove_theme_microdata_image_formatter.patch1.95 KB

Attached removes everything connected with theme_microdata_image_formatter(). Could add a requirement to microdata.info to for minimum core 7.14 but I don't think it's worth it.

jbrown’s picture

jbrown CreditAttribution: jbrown commented
Status: Needs review » Reviewed & tested by the community

This needs to be committed as it is preventing https://drupal.org/project/hires_images from working.

  • das-peter committed 67efab6 on 7.x-1.x authored by fenstrat 
    Issue #1875346 by fenstrat: Remove theme_microdata_image_formatter() as...
das-peter’s picture

das-peter CreditAttribution: das-peter commented
Issue summary: View changes
Status: Reviewed & tested by the community » Fixed

Could add a requirement to microdata.info to for minimum core 7.14 but I don't think it's worth it.

Why isn't it worth it?
Added.
Also added version hint on project page.

fenstrat’s picture

fenstrat
he/him
Primary language English
Location Australia
CreditAttribution: fenstrat commented

@das-peter Thanks for committing. My theory was 7.14 is old enough not to worry about, but better safe than sorry.

Nice to see some movement in the microdata queue, thanks for your work.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.