In #1873342: Remove redundant/un-needed settings from views UI we noticed there was some discussion around removing "Disable JS for Views UI". One reason to keep it in currently, is because we need it for accessibility - however as we push towards the new jQuery UI this bug will be removed.

However its kind of a one-off function, we don't have elsewhere in core (e.g. there is no disable JS on Fields UI, and probally also won't on the layout UI). Having this setting for Views UI is therefor supporting a usecase, I don't really see existing beyond those developing for views.

Two reasons xjm, mentioned is that somehow Views UI can be really slow because of JS. But its also a easy function to debug modules that extend Views.

CommentFileSizeAuthor
#8 interdiff-1874528-8.txt632 bytesdamiankloip
#8 1874528-8.patch3.97 KBdamiankloip
#6 1874528.patch3.88 KBdamiankloip

Comments

damiankloip’s picture

damiankloip commented

As in the other issue, +1 for this.

I don't think this should live in core, not for the purpose of easier debugging. A contrib module could in theory provide this pretty easily if they wanted to.

If it gets slow, that is something that should be looked at.

nod_’s picture

nod_
Primary language French
Location Lille
commented
Issue tags: +JavaScript

tag

xjm’s picture

xjm
she/her
Primary language English
commented
Status: Active » Postponed

Let's at least postpone this on the modals being accessible.

damiankloip’s picture

damiankloip commented

Whatever.

mgifford’s picture

mgifford
he/him
Primary language English
commented
Issue summary: View changes
Status: Postponed » Active

The modals are good. Is this issue still needed?

damiankloip’s picture

damiankloip commented
Status: Active » Needs review
StatusFileSize
new 1874528.patch3.88 KB

Yes, we still need this. The modals should be good now, and degrade fine. Using this setting completely breaks views UI anyway. Let's rip it out.

dawehner’s picture

dawehner
Primary language German
commented 
+++ b/core/modules/views_ui/src/ViewEditForm.php
@@ -107,10 +107,6 @@ public function form(array $form, FormStateInterface $form_state) {
-    if (!\Drupal::config('views.settings')->get('no_javascript')) {
-      $form['#attached']['library'][] = 'views_ui/views_ui.admin';
-    }

You forgot to drop the javascript as well. DIC

damiankloip’s picture

damiankloip commented
StatusFileSize
new 1874528-8.patch3.97 KB
new interdiff-1874528-8.txt632 bytes
damiankloip’s picture

damiankloip commented
Status: Needs review » Reviewed & tested by the community

daniel here: this is RTBC now. In general things like jquery update should solve the problem for their own.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 8: 1874528-8.patch, failed testing.

mgifford queued 8: 1874528-8.patch for re-testing.

The last submitted patch, 8: 1874528-8.patch, failed testing.

damiankloip queued 8: 1874528-8.patch for re-testing.

mgifford’s picture

mgifford
he/him
Primary language English
commented
Status: Needs work » Reviewed & tested by the community

Believe this was just the bot being a bit exhausted...

Still seems to apply easily.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 49eea51 and pushed to 8.0.x. Thanks!

  • alexpott committed 49eea51 on 8.0.x 
    Issue #1874528 by damiankloip | Bojhan: Remove "disable JS for Views UI...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.