Hi,

It would be nice if the Zencoder status api would be checked to provide transparancy from the api.
I provided a simple patch to see if the suggested approach is ok with you guys.

CommentFileSizeAuthor
#4 video-check_zencoder_status-1871992-4.patch1.64 KB30equals
#3 video-check_zencoder_status-1871992-3.patch1.35 KB30equals
#1 video-check_zencoder_status-1871992-1.patch1.34 KB30equals
video-check_zencoder_status.patch1.65 KB30equals

Comments

30equals’s picture

30equals commented
StatusFileSize
new video-check_zencoder_status-1871992-1.patch1.34 KB

mmm... patch isn't clean... new cleaned up one.

Jorrit’s picture

Jorrit commented
Status: Needs review » Needs work

You should use the Drupal methods to fetch files over HTTP and decode JSON. Also, I think it is best to put nl2br() outside of the t(), <br/> doesn't need to be translated.

30equals’s picture

30equals commented
Status: Needs work » Needs review
StatusFileSize
new video-check_zencoder_status-1871992-3.patch1.35 KB

I changed the patch according to your feedback. Hope it's fine now.

30equals’s picture

30equals commented
StatusFileSize
new video-check_zencoder_status-1871992-4.patch1.64 KB

New patch with http error handling and change use of t().

Jorrit’s picture

Jorrit commented
Status: Needs review » Fixed

Committed, thanks.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.