Problem/Motivation

This is a followup issue for #1535868: Convert all blocks into plugins.

  • #1535868: Convert all blocks into plugins removes the feature that allows individual users to configure whether or not certain blocks are displayed.
  • The feature probably does not need to be in core, since it's not that commonly used and can be easily implemented in contrib.
  • However, for sites that do make use of this feature, Drupal 8 will have a regression. If an existing site has (over)used this feature to allow users to pick a small subset of blocks to display from a long list, and they're suddenly all displayed on upgrade, the site might appear "broken".

Proposed resolution

Decide whether to restore this feature, or to let contrib provide it.

Comments

xjm’s picture

xjm
she/her
Primary language English
commented
Status: Active » Postponed
xjm’s picture

xjm
she/her
Primary language English
commented
Issue tags: +Blocks-Layouts
xjm’s picture

xjm
she/her
Primary language English
commented
Status: Postponed » Active
gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented

Per-user visibility JS was still in block.js, see #1882252: Regression: Block visibility summaries are broken

sun’s picture

sun
Primary language German
Location Karlsruhe
commented

Woah - this was removed??

The two visibility/access limiters, roles and paths, are actually the top-most used ones on all of my Drupal sites. I almost have a 100% hit rate on those, for every site, regardless of its scale or size. I have no idea why roles were removed. This is a major regression IMHO.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented

@sun: per *user* was removed, not per *role*, see OP.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented

Ooooh! I see :) Yeah, that's fine. Useless feature. :-D Sorry for the noise.

Bojhan’s picture

Bojhan commented

Agreed, per-user seems introduced in the "personalization" phase of the interwebs, where everything had to be per-user customizable. Perfectly fine to be done in contrib.

xjm’s picture

xjm
she/her
Primary language English
commented
Issue tags: +Block plugins
hosef’s picture

hosef commented

Shouldn't the issue status be "closed (won't fix)"? I have overheard several people say this was a done deal.

xjm’s picture

xjm
she/her
Primary language English
commented

@hosef, overheard where, and whom? This is a feature regression from D7, and there is no contrib solution. If we are going to permanently remove the feature, it needs core maintainer signoff, documented in this issue, and a change notice attached to the origininal BAP patch.

xjm’s picture

xjm
she/her
Primary language English
commented
Issue tags: +revisit before beta

At a minimum we need to do this.

benjy’s picture

benjy commented

+1 for removing it. If we get a core maintainer to agree i'll write the contrib module before release.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Title: Decide whether to restore per-user block visibility or provide it in contrib » Change notice: Decide whether to restore per-user block visibility or provide it in contrib
Priority: Normal » Critical
Status: Active » Needs work
Issue tags: +Needs change record

Discussed with @catch and we both agree that this feature does not need to be in Drupal 8. So @benjy go ahead and work on a contrib module - obviously bearing in mind blocks are currently undergoing some API work.

Also we need to update the change notice as per @xjm in #11.

benjy’s picture

benjy commented

Module created in contrib: https://drupal.org/project/per_user_block

We also need to remove some unused constants related to the per user block functionality which was removed: #2078675: Remove unused constants in block.module

catch’s picture

catch
he/him
Primary language English
commented
Priority: Critical » Major

#2083415: [META] Write up all outstanding change notices before release.

catch’s picture

catch
he/him
Primary language English
commented
Issue summary: View changes

Removing myself from the author field to unfollow the issue. --xjm

star-szr’s picture

star-szr
he/him
Primary language English
commented
Assigned: Unassigned » star-szr
Issue summary: View changes

I'll try to write a change notice for this.

star-szr’s picture

star-szr
he/him
Primary language English
commented
Assigned: star-szr » Unassigned
Status: Needs work » Needs review

Per-user block visibility customization functionality removed

Issues:
#1535868: Convert all blocks into plugins
#1871854: Decide whether to restore per-user block visibility or provide it in contrib

The feature to provide users with the ability to hide and show blocks from their user configuration page has been removed from Drupal core. This functionality is being built in the Per User Block contributed module.

The per-user customization feature shouldn't be confused with the ability for administrators to customize block visibility based on user roles that is still possible in Drupal 8 core.

Affects:

  • Site builders, administrators, editors
xjm’s picture

xjm
she/her
Primary language English
commented

Looks great.

xjm’s picture

xjm
she/her
Primary language English
commented
Issue summary: View changes
star-szr’s picture

star-szr
he/him
Primary language English
commented
Title: Change notice: Decide whether to restore per-user block visibility or provide it in contrib » Decide whether to restore per-user block visibility or provide it in contrib
Priority: Major » Normal
Status: Needs review » Fixed
Issue tags: -revisit before beta, -Needs change record

Thanks @xjm!

Change notice:
https://drupal.org/node/2152107

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.