Should the associated code be removed or converted into hook_node_view() implementation (as per http://api.drupal.org/api/drupal/developer%21hooks%21core.php/function/h...)?

CommentFileSizeAuthor
#1 webform-1869222-remove_hook_link.patch817 bytessimon georges

Comments

simon georges’s picture

simon georges commented
Status: Active » Needs review
StatusFileSize
new webform-1869222-remove_hook_link.patch817 bytes

Function removed.

quicksketch’s picture

quicksketch
he/him
commented

Thanks for this patch. Sorry it's getting me a while to get to it. In D7, Comment module emulates hook_link() by using hook_node_view() (I think). We should probably use this same approach rather than deleting the function entirely.

Marked #1889534: function webform_link does not seem to be working in Teasers, i.e. "Go to form" duplicate.

quicksketch’s picture

quicksketch
he/him
commented
Title: hook_link doesn't exist any more in D7 » Remove hook_link() implementation; doesn't exist any more in D7
Status: Needs review » Fixed

Actually considering #1713106: Remove "Show complete form in teaser" and all "teaser" hard-coded options (use view modes instead), I think just removing it is a fine suggestion. Committed to D7 branches.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.