The recent changes to the DrupalSolrQueryInterface::optimize() interface causes fatal errors for all implementing modules that don't also keep up with the change. In order to prevent all implementing modules from having to do a coupled release, we should revert the changes to the original state.

CommentFileSizeAuthor
#6 1868870-6-D6.patch4.74 KBpwolanin
#2 revert-interface-changes-1868870-2.patch4.56 KBcpliakas

Comments

cpliakas’s picture

cpliakas commented

From discussions with pwloanin, you shouldn't use optimize for Solr 4 anyways, so we can simply force the softCommit attribute to be true. People can override the method if they want to change this behavior.

cpliakas’s picture

cpliakas commented
Status: Active » Needs review
StatusFileSize
new revert-interface-changes-1868870-2.patch4.56 KB

The attached patch removes the interface changes and adds a method to the base DrupalApacheSolrService to set whether or not to use soft commits.

nick_vh’s picture

nick_vh
he/him
Location Ghent
commented
Status: Needs review » Reviewed & tested by the community

Looks good!

pwolanin’s picture

pwolanin commented
Version: 7.x-1.x-dev » 6.x-3.x-dev
Status: Reviewed & tested by the community » Patch (to be ported)

committed to 7.x

pwolanin’s picture

pwolanin commented

Is this duplicate with the other 4.0 patch now?

pwolanin’s picture

pwolanin commented
Status: Patch (to be ported) » Needs review
StatusFileSize
new 1868870-6-D6.patch4.74 KB

ported patch

pwolanin’s picture

pwolanin commented
Status: Needs review » Fixed

committed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.