It makes more sense (and we do that in the rest of views) that the options_* methods live together. It's just more convenient.

CommentFileSizeAuthor
#4 admin_views.1868510-4.patch7.31 KBdamiankloip
#1 admin_views.1868510.patch7.94 KBdamiankloip

Comments

damiankloip’s picture

damiankloip commented
Status: Active » Needs review
StatusFileSize
new admin_views.1868510.patch7.94 KB
damiankloip’s picture

damiankloip commented
Title: Reorder methods in views_plugin_display_system » Tidy and reorder methods in views_plugin_display_system
sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs review » Reviewed & tested by the community

Looks good.

+++ b/plugins/views_plugin_display_system.inc
@@ -129,7 +217,7 @@ class views_plugin_display_system extends views_plugin_display {
-      'access arguments' => $callbacks[$path]['access arguments'],
+      'access arguments' => !empty($callbacks[$path]['access arguments']) ? $callbacks[$path]['access arguments'] : array(),

Seems unrelated?

Wondering whether the menu system didn't set defaults already by the time this code is reached?

damiankloip’s picture

damiankloip commented
StatusFileSize
new admin_views.1868510-4.patch7.31 KB

Rerolled.

Yeah, it's a good point. I think we get into an odd situation with defaults. So we can get into a situation where user access is used and it expects an array, but just gets NULL...

sun’s picture

sun
Primary language German
Location Karlsruhe
commented

Looks good, passes tests :)

damiankloip’s picture

damiankloip commented
Status: Reviewed & tested by the community » Fixed

Committed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.