Export bundle 'config' field to features, and fix some features format issue.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

fmizzell’s picture

Priority: Normal » Critical
garphy’s picture

Title: Export bundle 'config' field to features, and fix some features format issue. » Export bundle 'config' field to features

I think it may be better to split this issue.
Exporting bundle 'config' key is critical but pretty printing the feature generated code is not and should be moved to a separate issue (with the corresponding patch).
The patch for the remaining concerns of this issue would become trivial and more prone to be quickly reviewed & committed.

romsP’s picture

I totally agree with you.

garphy’s picture

The patch works great here.
We now have 'language' related bundle settings included in features exports as well as our custom 'tsid' property bundle settings (see eck_i18n sandbox[1]).
IMHO this is a useful one-liner patch that should be committed.

Would be great is someone else who tested this fix could post its feedback in order to RTBC this issue.

[1] http://drupal.org/sandbox/garphy/1966680

simonyeldon’s picture

Had a look at the single line patch that adds config to the export array and it is exactly what we need.

Works perfectly, although I might suggest that we have the contents in alphabetical order (as that is what features 2 exports it as).

It would be good if this could be merged.

simonyeldon’s picture

Issue summary: View changes
FileSize
369 bytes

Re-rolling the patch to allow it to be applied against the current Master.

kolier’s picture

Patch #6 is wrong, re-show patch #3.

marcusx’s picture

Testet patch from #3 https://www.drupal.org/node/1867614#comment-7463046. Can confirm that this adds language settings to the feature.

axe312’s picture

Status: Needs review » Reviewed & tested by the community

I can confirm that patch #3 works with my RC4 installation of eck.

I had to force revert the features, but finally the bundle settings were updated on our development instance.

fmizzell’s picture

Category: Feature request » Bug report

I guess if some config that eck supports is not going into a feature that is a bug, and not a feature..

joelstein’s picture

+1 for the patch in #3.

Also note that it's currently impossible to revert bundles in Features, but this is fixed with the patch in #1733312-3: Bundles duplicates can be created from code - Features revert with bundles creates duplicates.

  • fmizzell committed 3cbea0f on 7.x-2.x authored by romsP
    Issue #1867614 by simonyeldon, kolier, romsP: Export bundle 'config'...
fmizzell’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.